Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lower no base token ratio log level #3141

Merged
merged 1 commit into from
Oct 24, 2024
Merged

chore: lower no base token ratio log level #3141

merged 1 commit into from
Oct 24, 2024

Conversation

itegulov
Copy link
Contributor

What ❔

Lowers no base token ratio log level to WARN instead of ERROR

Why ❔

It gets printed >500 times during integration tests making it hard to find the actual errors.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@itegulov itegulov added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@itegulov itegulov added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 04f4dae Oct 24, 2024
34 checks passed
@itegulov itegulov deleted the daniyar/lower-ratio-log-level branch October 24, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perekopskiy perekopskiy perekopskiy approved these changes

@shahar4 shahar4 Awaiting requested review from shahar4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itegulov @perekopskiy