Sync interop tests #3156
Merged
Sync interop tests #3156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details: |
kelemeno
reviewed
Oct 23, 2024
| interop2: string; | ||
| }; | ||
| }; | ||
| let tokenB_details: { |
There was a problem hiding this comment.
tokenDetails struct should be used
There was a problem hiding this comment.
export interface Token {
name: string;
symbol: string;
decimals: bigint;
l1Address: string;
l2Address_1: string;
l2Address_2:string;
assetId: string;
}
kelemeno
reviewed
Oct 23, 2024
| const timeout = 10000; | ||
|
|
||
| // Interop1 (Main Chain) Variables | ||
| let interop1_provider: zksync.Provider; |
There was a problem hiding this comment.
maybe chain1 is a better name? but its just a nit
kelemeno
reviewed
Oct 23, 2024
| to: interop2_wallet.address, | ||
| approveERC20: true, | ||
| approveBaseERC20: true, | ||
| approveOverrides: { gasPrice }, |
kelemeno
reviewed
Oct 23, 2024
| l1Bridgehub = new ethers.Contract(l1BridgehubAddress, bridgehubInterface, l1Wallet); | ||
| const chainAddress = await l1Bridgehub.getHyperchain(secondChainId); | ||
|
|
||
| tokenDetails = testMaster.environment().erc20Token; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.