Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zksync_cli): Health checkpoint improvements #3193

Merged
merged 70 commits into from
Nov 26, 2024

Conversation

manuelmauro
Copy link
Contributor

@manuelmauro manuelmauro commented Oct 29, 2024

What ❔

Add three new components to node's healthcheck:

  • General (i.e., version, last migration)
  • State Keeper
  • Eth Sender

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@manuelmauro manuelmauro marked this pull request as ready for review November 4, 2024 14:30
core/lib/dal/src/system_dal.rs Outdated Show resolved Hide resolved
core/lib/git_version_macro/src/lib.rs Outdated Show resolved Hide resolved
core/node/house_keeper/src/database.rs Outdated Show resolved Hide resolved
core/node/house_keeper/src/eth_sender.rs Outdated Show resolved Hide resolved
core/node/house_keeper/src/eth_sender.rs Outdated Show resolved Hide resolved
etc/env/file_based/general.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. If this functionality isn't urgent, I'd still prefer at least non-nit / bikeshedding comments be addressed in this PR.

core/lib/dal/src/system_dal.rs Outdated Show resolved Hide resolved
core/node/eth_sender/src/health.rs Outdated Show resolved Hide resolved
core/node/shared_metrics/src/binary.rs Outdated Show resolved Hide resolved
core/node/shared_metrics/build.rs Outdated Show resolved Hide resolved
core/node/shared_metrics/src/binary.rs Outdated Show resolved Hide resolved
core/node/state_keeper/src/keeper.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Deniallugo Deniallugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, please fix the last comment from @slowli

slowli
slowli previously approved these changes Nov 21, 2024
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are nits; I've left them mostly to be addressed in a follow-up PR. I can produce such a PR once I've got less swamped with tasks 🙃

core/lib/health_check/Cargo.toml Show resolved Hide resolved
core/lib/bin_metadata/src/lib.rs Show resolved Hide resolved
@manuelmauro
Copy link
Contributor Author

manuelmauro commented Nov 21, 2024

Comments are nits; I've left them mostly to be addressed in a follow-up PR. I can produce such a PR once I've got less swamped with tasks 🙃

No worries! I can address them here. 👍 Thanks for the review!

@Deniallugo Deniallugo enabled auto-merge November 26, 2024 09:30
@Deniallugo Deniallugo added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 440fe8d Nov 26, 2024
32 checks passed
@Deniallugo Deniallugo deleted the manuel-add-more-components-to-healthcheck branch November 26, 2024 10:07
github-merge-queue bot pushed a commit that referenced this pull request Dec 5, 2024
## What ❔

Various minor follow-ups after
#3193:

- Rework app-level health details.
- Fix `execution_time` unit of measurement for the database health check
details.
- Rework the database health check: do not hold a DB connection all the
time; make it reactive.

## Why ❔

Makes the dependency graph lighter; simplifies maintenance.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[25.3.0](core-v25.2.0...core-v25.3.0)
(2024-12-11)


### Features

* change seal criteria for gateway
([#3320](#3320))
([a0a74aa](a0a74aa))
* **contract-verifier:** Download compilers from GH automatically
([#3291](#3291))
([a10c4ba](a10c4ba))
* integrate gateway changes for some components
([#3274](#3274))
([cbc91e3](cbc91e3))
* **proof-data-handler:** exclude batches without object file in GCS
([#2980](#2980))
([3e309e0](3e309e0))
* **pruning:** Record L1 batch root hash in pruning logs
([#3266](#3266))
([7b6e590](7b6e590))
* **state-keeper:** mempool io opens batch if there is protocol upgrade
tx ([#3360](#3360))
([f6422cd](f6422cd))
* **tee:** add error handling for unstable_getTeeProofs API endpoint
([#3321](#3321))
([26f630c](26f630c))
* **zksync_cli:** Health checkpoint improvements
([#3193](#3193))
([440fe8d](440fe8d))


### Bug Fixes

* **api:** batch fee input scaling for `debug_traceCall`
([#3344](#3344))
([7ace594](7ace594))
* **tee:** correct previous fix for race condition in batch locking
([#3358](#3358))
([b12da8d](b12da8d))
* **tee:** fix race condition in batch locking
([#3342](#3342))
([a7dc0ed](a7dc0ed))
* **tracer:** adds vm error to flatCallTracer error field if exists
([#3374](#3374))
([5d77727](5d77727))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants