-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port the gateway release candidate + use forge #3212
base: sync-layer-stable
Are you sure you want to change the base?
Conversation
Hey there! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed upgrade part in zkstack_cli yet
core/node/eth_watch/src/tests.rs
Outdated
async fn get_published_preimages( | ||
&self, | ||
_hashes: Vec<H256>, | ||
) -> EnrichedClientResult<Vec<Option<Vec<u8>>>> { | ||
Ok(vec![]) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have some unit test with factory dep in upgrade
core/node/node_framework/src/implementations/layers/eth_watch.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: perekopskiy <[email protected]>
…forge-for-contracts
What ❔
Why ❔
Checklist
zkstack dev fmt
andzkstack dev lint
.