Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configs): Update calldata after v25 #3217

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sanekmelnikov
Copy link
Collaborator

What ❔

Updated diamond_cut_data after v25 upgrade on Sepolia.

Why ❔

Diamond cut data is incorrect and registration of new chains are failing.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@sanekmelnikov
Copy link
Collaborator Author

Another problem is that bootloader and default_aa addresses are not matching the ones actually deployed on testnet:

cast rpc zks_getProtocolVersion --rpc-url https://sepolia.era.zksync.dev | jq '.'
{
  "base_system_contracts": {
    "bootloader": "0x010008c3be57ae5800e077b6c2056d9d75ad1a7b4f0ce583407961cc6fe0b678",
    "default_aa": "0x0100055dba11508480be023137563caec69debc85f826cb3a4b68246a7cabe30",
    "evm_emulator": null
  },
  "bootloaderCodeHash": "0x010008c3be57ae5800e077b6c2056d9d75ad1a7b4f0ce583407961cc6fe0b678",
  "defaultAccountCodeHash": "0x0100055dba11508480be023137563caec69debc85f826cb3a4b68246a7cabe30",
  "evmSimulatorCodeHash": null,
  "l2SystemUpgradeTxHash": "0xd3086b71c95ce83e7f3d30ab1890ada2334695a05b65715e56f42d96b22c8674",
  "l2_system_upgrade_tx_hash": "0xd3086b71c95ce83e7f3d30ab1890ada2334695a05b65715e56f42d96b22c8674",
  "minorVersion": 25,
  "timestamp": 1729793768,
  "verification_keys_hashes": {
    "recursion_scheduler_level_vk_hash": "0x0000000000000000000000000000000000000000000000000000000000000000"
  },
  "version_id": 25
}

But zkstack dev generate-genesis keeps generating different addresses
@koloz193, @perekopskiy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant