chore: Add logging to witness generator db save #3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of prover infra relies on tracing. Tracing is not available on all environments. As such, troubleshooting issues covered by tracing is not possible. A recent service degradation could not be troubleshot due to lack of tracing. This line enables troubleshooting even when tracing is not available.
Artemka374
approved these changes
Jan 29, 2025
EmilLuta
deleted the
evl-add-witness-geenrator-logging-for-non-tracing-envs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of prover infra relies on tracing. Tracing is not available on all environments. As such, troubleshooting issues covered by tracing is not possible. A recent service degradation could not be troubleshot due to lack of tracing. This line enables troubleshooting even when tracing is not available.
What ❔
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.