Contracts cleanup #190
Merged
Contracts cleanup #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpb8010
approved these changes
Nov 20, 2024
| /// @dev It is not implemented yet. | ||
| /// @param _transaction The transaction data. | ||
| function executeTransactionFromOutside(Transaction calldata _transaction) external payable override { | ||
| revert Errors.METHOD_NOT_IMPLEMENTED(); |
ly0va
approved these changes
Nov 20, 2024
ly0va
added a commit
that referenced
this pull request
Nov 22, 2024
* feat: proxies, deploy scripts and cleanup * fix: update addresses * fix: cspell * fix: some fixes * fix: --no-proxy * fix: post-merge fixes * Contracts cleanup (#190) * refactor: improve code quality * fix: compilation * fix: implement Efficient Proxy, fix batch calss * fix: final bit of renaming * fix: basic tests * fix: use default upgradeable beacon * fix: pre-audit changes (#191) * refactor: small refactoring * fix: sessions paymaster input * refactor: contract AAFactory * chore: remove erc7579 stuff * fix: update addresses --------- Co-authored-by: Vlad Bochok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context