No hook interface #208
Draft
No hook interface #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove clave interface for validation, only need one interface
Would love to have a single interface, but 1271 makes the extra transaction argument difficult, so an easy workaround is just having two Having them named the same is also slightly confusing when one is only called from isValidSignature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces validation hook with a module validation signature that includes the transaction.
Additional context
The two step validation hook + module validation was needlessly complicated. It should have been rare for an external transaction to call isValidSignature as part of a session, but the validation flow was built around it.
Now that's supported via the same temporary transaction storage as before, but not as the primary path.
This was a long running interface debt between Clave and a partially implemented 7579 validation module.