Feature/Neshan Map #179
Feature/Neshan Map #179
Conversation
|
hey sorry completely missed it. let me check. |
| @@ -72,7 +73,8 @@ private let maps: [Map] = [ | |||
| Map(mapName: "Naver Map", mapType: MapType.naver, urlPrefix: "nmap://"), | |||
| Map(mapName: "Kakao Maps", mapType: MapType.kakao, urlPrefix: "kakaomap://"), | |||
| Map(mapName: "TMap", mapType: MapType.tmap, urlPrefix: "tmap://"), | |||
| Map(mapName: "Mapy CZ", mapType: MapType.mapyCz, urlPrefix: "szn-mapy://") | |||
| Map(mapName: "Mapy CZ", mapType: MapType.mapyCz, urlPrefix: "szn-mapy://"), | |||
| Map(mapName: "Neshan Map", mapType: MapType.neshan, urlPrefix: "nshn.ir/") | |||
There was a problem hiding this comment.
"nshn.ir/" does not look like a valid url scheme I don't think it's going to work
There was a problem hiding this comment.
I tested it and it works completely, Neshan App doesn't have a custom scheme it has an HTTP deep link
There was a problem hiding this comment.
it may launch it but it won't be shown in the list of available maps.
you sure neshan:// doesn't work?
There was a problem hiding this comment.
it shows in the list of available maps
available maps are based on package name I think
There was a problem hiding this comment.
on android yes, I'm talking about iOS
assets/icons/neshan.png
Outdated
There was a problem hiding this comment.
icon needs to be an svg with an opaque background. you can download a logo from app store and convert to svg
| @@ -188,6 +189,7 @@ if (await MapLauncher.isMapAvailable(MapType.google)) { | |||
| | `.flitsmeister` | ✓ | ✗ | always uses current location | ✗ | ✗ | ✗ | ✗ | | |||
| | `.truckmeister` | ✓ | ✗ | always uses current location | ✗ | ✗ | ✗ | ✗ | | |||
| | `.sygicTruck` | ✓ | ✗ | always uses current location | ✗ | ✗ | ✗ | ✗ | | |||
| | `.neshan` | ✓ | ✗ | ✓ | ✗ | ✓ | ✗ | ✗ | | |||
There was a problem hiding this comment.
could you also add an entry into the Show Marker section
|
@mattermoran Can you please check again? |
|
@mattermoran any update? |
|
?? |
|
hey. sorry had lots going on. |
Add Neshan Map (nshn.ir)