Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Bug:After deleting a board, using the undo feature would redire… #4868

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

V1nnncJune
Copy link

@V1nnncJune V1nnncJune commented Sep 9, 2023

Summary
After deleting a board, using the undo feature would redirect to an error page displaying "board-not-found." After reviewing the code, I swapped the order of the undo operation in the deleteBoard function, ensuring that the server data is updated first before redirecting to the page. This change allows for undoing board deletion without encountering an error.

…ct to an error page displaying "board-not-found."
@mattermost-build
Copy link
Contributor

Hello @V1nnncJune,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@sbishel
Copy link
Collaborator

sbishel commented Sep 27, 2023

/update-branch

@V1nnncJune
Copy link
Author

/update-branch

Hello, in the merge request for this issue, I only made a modification to one line of code. However, it's showing that the automated script did not pass. How should I address this problem, or is there an issue with the script itself?

@giuseongit
Copy link

@V1nnncJune please note that this entire project seems quite abandoned, I found this fork following this discussion that could be a replacement for a community-driven product

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants