Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mm-66] - provides a better date selection ui #83

Closed

Conversation

maisnamrajusingh
Copy link
Contributor

@maisnamrajusingh maisnamrajusingh commented Jul 15, 2021

Summary

Provides a way to select the date format

Ticket Link

Fixes #66

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #83 (819dd93) into master (2f22484) will increase coverage by 3.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   26.03%   29.05%   +3.02%     
==========================================
  Files           7        7              
  Lines         315      351      +36     
==========================================
+ Hits           82      102      +20     
- Misses        216      232      +16     
  Partials       17       17              
Impacted Files Coverage Δ
server/meeting.go 67.30% <100.00%> (+4.26%) ⬆️
server/main.go 0.00% <0.00%> (ø)
server/command.go 0.00% <0.00%> (ø)
server/manifest.go 100.00% <0.00%> (ø)
server/configuration.go 0.00% <0.00%> (ø)
server/utils.go 95.12% <0.00%> (+1.18%) ⬆️
server/plugin.go 25.74% <0.00%> (+3.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f22484...819dd93. Read the comment docs.

@hanzei hanzei requested a review from mickmister July 15, 2021 07:11
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Jul 15, 2021
@maisnamrajusingh
Copy link
Contributor Author

@mickmister @jfrerich I am sending two other PRs, but this one will have to be merged before they can be accepted as they were done initially without much thought in the initial days. Sorry for any headaches this might cause.

@hanzei hanzei added Invalid This doesn't seem right and removed 2: Dev Review Requires review by a core committer labels Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve date format selection UI
2 participants