Unknown type messages support #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmister
reviewed
Apr 23, 2024
There was a problem hiding this comment.
Awesome work @danilvalov 🎉
Just one suggestion to control this behavior via a plugin setting, so the admin can turn this off if desired.
We would add it here
and use it like the other plugin settings throughout the plugin
server/plugin.go
Outdated
| @@ -267,6 +268,8 @@ func (p *Plugin) handleNotification(body io.Reader, channel *TeamChannel) { | |||
| p.sendPostNotification(p.createSNSMessageNotificationAttachment(notification.Subject, messageNotification), channel) | |||
| return | |||
| } | |||
|
|
|||
| p.sendPostNotification(p.createSNSUnknownTypeMessage(notification.Subject, notification.Message), channel) | |||
There was a problem hiding this comment.
I'm thinking this behavior should be configurable in a plugin setting
There was a problem hiding this comment.
@mickmister I'm not sure if I described this option correctly in Settings. Check, please
mickmister
added
2: Dev Review
danilvalov
force-pushed
the
feature/unknown-type-messages-support
branch
from
ae63a3b
to
4afae68
Compare
mickmister
approved these changes
Apr 25, 2024
Co-authored-by: Michael Kochell <[email protected]>
mickmister
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for unknown type events.
Parses and formates JSON (if the message is in JSON format) or sends plain text