[MM-75] Update plugin with respect to phase 1 upgrades #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmister
reviewed
Feb 15, 2024
There was a problem hiding this comment.
@ayusht2810 There are no webapp components in this repo so the webapp folder can be deleted. Can you please delete that folder and the section in the plugin.json file for the webapp? Thanks
…icenow-virtual-agent into MM-75
|
@mickmister fixed the review comments. Please re-review. |
…s (#192) * Revert "Update main.go (#154)" This reverts commit be4a281. * Revert "[MM-33506] Use embed package to include plugin manifest (#145)" This reverts commit ca9ee3c. * Revert "Don't generate manifest.ts (#127)" This reverts commit 18d30b5. * install-go-tools target, adopt gotestsum * bring back make apply + automatic versioning * Update build/manifest/main.go Co-authored-by: Michael Kochell <[email protected]> * suppress git describe error when no tags match * make version/release notes opt-in * fix whitespace in Makefile * document version management options --------- Co-authored-by: Michael Kochell <[email protected]>
Co-authored-by: Jesse Hallam <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
==========================================
- Coverage 64.75% 64.70% -0.05%
==========================================
Files 17 17
Lines 1444 1445 +1
==========================================
Hits 935 935
- Misses 465 466 +1
Partials 44 44 ☔ View full report in Codecov by Sentry. |
mickmister
reviewed
Feb 20, 2024
| # You can include assets this directory into the bundle. This can be e.g. used to include profile pictures. | ||
| ASSETS_DIR ?= assets | ||
|
|
||
| ## Generates mock golang interfaces for testing | ||
| .PHONY: mock |
There was a problem hiding this comment.
This needs to be relocated to build/custom.mk. Wondering if there are similar issues in other starter template sync PRs
…icenow-virtual-agent into MM-75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated plugin with respect to phase 1 upgrades
buildfolder to sync with starter templatenvmrcfile and updatepackage-lock.jsonfile.Ticket Link