Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Welcome bot will not let me add a message to private channels #72

Open
DHaussermann opened this issue May 28, 2021 · 4 comments · Fixed by #79 · May be fixed by #132
Open

Welcome bot will not let me add a message to private channels #72

DHaussermann opened this issue May 28, 2021 · 4 comments · Fixed by #79 · May be fixed by #132
Labels
Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/Go Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers
Milestone
v1.4.0

Comments

@DHaussermann
Copy link

Seems like the feature of adding a channel level welcome message should work for both public and private channels.
When I try using this feature I see a message saying this is not supported for DM channels. However the channel is not a DM.
image

Steps:

  • Create or open any private channel
  • Type /welcomebot set_channel_welcome "I like pickles"
    Observed: welcome messages are not supported for direct channels
@DHaussermann DHaussermann added Triage Type/Bug Something isn't working labels May 28, 2021
@hanzei
Copy link
Contributor

hanzei commented May 29, 2021

It works exactly like the code dictates it: https://github.com/mattermost/mattermost-plugin-welcomebot/blob/29c0079329652a42c852ade6aa9309359777f22b/server/command.go#L133-L136

@hanzei hanzei removed the Triage label Jun 1, 2021
@eng-user01
Copy link

I was surprised to run into this (why shouldn't it work in a private channel?) and confused by the misleading error message.

@hanzei
Copy link
Contributor

hanzei commented Jun 17, 2021

Yes, the code is wrong. Only direct channels should be prohibited, not private ones.

@hanzei hanzei added Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers labels Jun 17, 2021
@maisnamrajusingh maisnamrajusingh mentioned this issue Jun 27, 2021
Merged
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Jun 27, 2021
@hanzei hanzei linked a pull request Jun 27, 2021 that will close this issue
solves Gh 72 - Welcome bot will not let me add a message to private channels #79
Merged
@mickmister mickmister mentioned this issue May 4, 2023
Merged
@mickmister
Copy link
Contributor

Reopening since the fix PR has been reverted #109

@mickmister mickmister reopened this May 4, 2023
@hanzei hanzei added the Up For Grabs Ready for help from the community. Removed when someone volunteers label May 16, 2023
@Kshitij-Katiyar Kshitij-Katiyar added this to the v1.4.0 milestone Apr 12, 2024
@ayusht2810 ayusht2810 linked a pull request Apr 18, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/Go Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Milestone
v1.4.0
6 participants
@mickmister @jfrerich @hanzei @DHaussermann @eng-user01 @Kshitij-Katiyar