Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solves Gh 72 - Welcome bot will not let me add a message to private channels #79

Merged
merged 1 commit into from
Jun 28, 2021
Merged

solves Gh 72 - Welcome bot will not let me add a message to private channels #79

merged 1 commit into from
Jun 28, 2021

Conversation

maisnamrajusingh
Copy link
Contributor

Summary

Welcome bot will not let me add a message to private channels

Ticket Link

#72

@mattermod
Copy link
Contributor

Hello @maisnamrajusingh,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

hanzei
hanzei approved these changes Jun 27, 2021
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Jun 27, 2021
@hanzei hanzei added this to the v1.3.0 milestone Jun 27, 2021
@hanzei hanzei linked an issue Jun 27, 2021 that may be closed by this pull request
Welcome bot will not let me add a message to private channels #72
Open
jfrerich
jfrerich approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks!

@jfrerich jfrerich added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Jun 28, 2021
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jun 28, 2021
@hanzei
Copy link
Contributor

hanzei commented Jun 28, 2021

Skipping QA review per offline dicussion.

@hanzei hanzei merged commit 517c73e into mattermost-community:master Jun 28, 2021
@hanzei
Copy link
Contributor

hanzei commented Jul 16, 2021

@maisnamrajusingh Does https://github.com/demansoltech/mattermost-plugin-welcomebot/blob/9c84d495fa0440499d74d0fde142c965b03de14c/server/hooks.go#L38-L39 also need to be changed?

@hanzei hanzei mentioned this pull request Jul 16, 2021
Closed
@mickmister mickmister mentioned this pull request Apr 28, 2023
Merged
mickmister added a commit that referenced this pull request May 4, 2023
@mickmister
Revert "solves Gh 72 - Welcome bot will not let me add a message to p…
a501877 
…rivate channels (#79)"

This reverts commit 517c73e.
@mickmister mickmister mentioned this pull request May 4, 2023
Merged
mickmister added a commit that referenced this pull request May 10, 2023
@mickmister
Revert #82 and #79 (#109)
f982137 
* Revert "solves Gh 72 - Welcome bot will not let me add a message to private channels (#79)"

This reverts commit 517c73e.

* Revert "[mm-65] Allows users to add multiple teams to the messages using `team-a,team-b` in the messages (#82)"

This reverts commit 03ea722.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

@jfrerich jfrerich jfrerich approved these changes

@DHaussermann DHaussermann Awaiting requested review from DHaussermann

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Welcome bot will not let me add a message to private channels
5 participants
@maisnamrajusingh @mattermod @hanzei @jfrerich @maisnamraju