Add configuration via system console #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levb
approved these changes
Jun 21, 2022
levb
reviewed
Jun 21, 2022
jfrerich
approved these changes
Jul 27, 2022
hanzei
added
3: QA Review
Co-authored-by: Jason Frerich <[email protected]>
catalintomai
approved these changes
Oct 14, 2022
|
@AayushChaudhary0001 Would you be open to reviewing this PR? |
hanzei
requested review from
AayushChaudhary0001
and removed request for
DHaussermann
|
Note that there is a similar PR being finished up that implements a custom admin component for this Brightscout#15. I think this PR can/should be closed in favor of the custom component implementation. Are you okay with this @jwilander? |
|
Yes, let's close in favour of that. |
|
Opening this PR due to comments #108 (comment) and #108 (comment). |
There was a problem hiding this comment.
@Kshitij-Katiyar While testing this PR, it was found that this was not working for MM cloud server. Any new user added to a team was not getting any welcome message nor any action button. Please verify it once.
|
Closing the PR because of the PR #126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I wanted to make this plugin configurable via the System Console, since doing it with mmctl was causing me issues and I wanted to update it often. But, because the plugin manifest settings schema only offers strings and other primitive types as options, I needed the configuration for
WelcomeMessagesto support being either a string or a JSON array. Hence, the customUnmarshalJSONforConfiguration.It's not an ideal solution but it works decently well. The other method I considered taking was using the
customsettings schema type but then I'd have to re-implement the text field component and add a web app component to this plugin, which I didn't want to do. Thoughts?