Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and standardize stats calculations #42

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Simplify and standardize stats calculations #42

merged 1 commit into from
Oct 11, 2024

Conversation

streamer45
Copy link
Contributor

Summary

Simplifying a bunch of things that caused confusion (and bugs):

  • Latency and jitter are now calculated in seconds.
  • round trip time is calculated only in one way (by us through ping/pong). No need to mess with candidates since they add complexity and have poor support (e.g. Firefox).

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Oct 10, 2024
@streamer45 streamer45 self-assigned this Oct 10, 2024
cpoile
cpoile approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I'm always in favor of simplifying!

src/rtc_monitor.ts Show resolved Hide resolved
@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 11, 2024
@streamer45 streamer45 merged commit 07607cf into master Oct 11, 2024
4 checks passed
@streamer45 streamer45 deleted the MM-60561 branch October 11, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpoile cpoile cpoile approved these changes

Assignees

@streamer45 streamer45

Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@streamer45 @cpoile