Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporated DB setup updates #6559

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Conversation

cwarnermm
Copy link
Member

No description provided.

@cwarnermm cwarnermm added this to the v8.1.0 milestone Jul 28, 2023
@github-actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA ecec9a6

@cwarnermm cwarnermm requested a review from nab-77 August 1, 2023 16:47
@cwarnermm cwarnermm added the 1: PM Review Requires review by a product manager label Aug 1, 2023
Copy link
Contributor

@nab-77 nab-77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good with the changes but I keep coming back to how much we need to document re the service stack. Here this is how to setup pgsql on RHEL (and its nuances). We just need a pgsql to connect to (and there for only need to define the perms needed for the mm dm user).

@github-actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 1547911

@cwarnermm
Copy link
Member Author

@nab-77 @coltoneshaw - My latest commit to this docs PR attempts to simplify the RHEL install docs page and align it with our new approach (parallel to Ubuntu and tarball).

Under the covers, I've turned the common steps into reusable components we can share between RHEL and tarball (since a signed package for RHEL isn't yet available), which reduces/eliminates content duplication risk.

@coltoneshaw - This latest commit also takes your updates via #6576 into account. Please review this PR to ensure that I've included all of your updates specific to RHEL installs. Right now, I believe this RHEL page is very v8 specific and may need additional updates to capture relevant v7 details. Please let me know.

@nab-77 - This latest commit includes updates to the database install page to account for @coltoneshaw's corrections specific to RHEL. I agree with your feedback that this page was too instruction-heavy and needed to be brought in line with our other simplified install pages. All feedback is welcome.

To review the changes in context using the generated preview, please visit:

@cwarnermm cwarnermm added the 1: Dev Review Requires review by a core commiter label Aug 10, 2023
@@ -124,16 +188,16 @@ To set up a PostgreSQL database for use by the Mattermost server:

.. code-block:: none
:class: mm-code-block


psql --dbname=mattermost --username=mmuser --password

.. tab:: Multi-server deployment
Copy link
Contributor

@nab-77 nab-77 Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this not a case of multi-server deployment, rather better phrased as "db on the same server as mattermost" or "db on a remote system".

0/5 on the terms but the concept is there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coltoneshaw - What terminology do you tend to hear from customers when differentiating between a deployment where all components are on a single server versus components spread across servers?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'd +1 neil on this one. Although, both are technically correct. I'd lean towards DB on another server

@@ -3,169 +3,99 @@
Install Mattermost on RHEL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that the code blocks in-line with text do not seem to have the style applied (i.e. the colour)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide an example?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On https://docs.mattermost.com/install/install-tar.html you can see the in-line code is the same blue as the code boxes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 1cd79a8

@cwarnermm cwarnermm requested a review from nab-77 August 15, 2023 13:13
@cwarnermm
Copy link
Member Author

@nab-77 @coltoneshaw - This docs PR is ready for your review.

@github-actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 3a605e2

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter 1: PM Review Requires review by a product manager labels Aug 15, 2023
@cwarnermm cwarnermm merged commit 66a0a3a into v8.1-documentation Aug 15, 2023
3 checks passed
@cwarnermm cwarnermm deleted the rhel-deploy-updates-for-v8 branch August 15, 2023 13:29
amyblais added a commit that referenced this pull request Aug 24, 2023
* Update conf.py

* Added support for hiding guest badges (#6556)

* Added support for disabling guest badges

* Update source/onboard/guest-accounts.rst

* Clarified guest & system admin access (#6558)

* Removing a server not obvious on mobile (#6562)

* Added support for custom forgot password flow/URL (#6557)

* Added support for custom forgot password flow/URL

* Incorporated reviewer feedback

* Update source/configure/site-configuration-settings.rst

* SSL needed for copy link feature for non-secure deployments (#6563)

* SSL to share links in non-secure deployments

* Incorporated reviewer feedback

* Update source/onboard/ssl-client-certificate.rst

* CLI docs cleanup to remove legacy commands (#6561)

* CLI docs cleanup to remove legacy commands

* Updated remaining references & added redirects

* Removed remaining deprecated CLI references (#6580)

* Build fixes

* Clearly labeled third-party plugins (#6584)

* Clearly labeled all third-party plugin configs

* Added back necessary search metadata

* v8.1 Release Notes (#6551)

* Update self-managed-changelog.md

* Update extended-support-release.rst

* Update open-source-components.rst

* Update release-lifecycle.rst

* Update self-managed-changelog.md

* Update self-managed-changelog.md

* Update self-managed-changelog.md

* Update self-managed-changelog.md

* Update source/install/self-managed-changelog.md

Co-authored-by: Guillermo Vayá <[email protected]>

* Fix typo

* Update self-managed-changelog.md

* Update self-managed-changelog.md

* Update self-managed-changelog.md

* Update self-managed-changelog.md

* Update self-managed-changelog.md

* Update self-managed-changelog.md

* Update self-managed-changelog.md

* Update install-tar.rst

* Update self-managed-changelog.md

* Update extended-support-release.rst

* Update release-lifecycle.rst

* Update prepare-to-upgrade-mattermost.rst

* Update important-upgrade-notes.rst

* Update version-archive.rst

---------

Co-authored-by: Guillermo Vayá <[email protected]>

* Key self-hosted config setting recommendations for large file imports (#6571)

* Large file import config setting recommendations

* Clarified configs are for self-hosted deployments only

* Incorporated reviewer feedback

* Incorporated DB setup updates (#6559)

* Incorporated DB setup updates

* Simplified RHEL install instructions

* Incorporated reviewer feedback

* Update self-managed-changelog.md

---------

Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
Co-authored-by: Guillermo Vayá <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants