Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove horizontal table scroll #7414

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Conversation

cwarnermm
Copy link
Member

@cwarnermm cwarnermm commented Sep 19, 2024

Introduces CSS that enables table wrapping on simple RST tables via .. table:: Sphinx directive. Concept taken from here

@cwarnermm cwarnermm added the Work In Progress Not yet ready for review label Sep 19, 2024
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 1405edd

@emdecr
Copy link
Contributor

emdecr commented Sep 20, 2024

@cwarnermm As per our call – the new table at the top looks good! I think the 100% max-width did the trick? It's weird because I can't see the class you used .wy-table-responsive in the page markup. We can keep chatting, but TL;DR - your changes seem to have done the trick.

@hmhealey
Copy link
Member

I don't see the issue on the new table, but the offending code block there has been manually wrapped to not have the issue. I don't think the CSS that you added is actually being used

@cwarnermm
Copy link
Member Author

I suspect the same @hmhealey -- that the CSS code isn't being used because the extra long line is being handled correctly. I'll pull out the CSS and confirm our suspicions, and then move forward with the full PR lift.

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 22ddc0d

@cwarnermm cwarnermm changed the title POC to remove horizontal table scroll Remove horizontal table scroll Sep 27, 2024
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 68f3369

@cwarnermm
Copy link
Member Author

Confirmed that CSS is unnecessary. Reformatting all SQL code blocks that exceed the center pane width successfully eliminates the horizontal scroll and cut off text display.

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 7192d40

@cwarnermm cwarnermm removed the Work In Progress Not yet ready for review label Sep 27, 2024
@cwarnermm cwarnermm merged commit 21439d6 into master Sep 27, 2024
4 checks passed
@cwarnermm cwarnermm deleted the important-upgrade-notes-table-wrap branch September 27, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants