Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated as per Issue #7428 #7435

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Updated as per Issue #7428 #7435

merged 4 commits into from
Oct 2, 2024

Conversation

1510janu
Copy link
Contributor

@1510janu 1510janu commented Oct 2, 2024

Updated as per Issue #7428

Added:

  1. A bullet point under section - 'Log in using the desktop app' 2. 'Desktop App displays white screen while launching and doesn't load the page' under the section - 'Troubleshooting your Desktop App installation'.

Summary

Ticket Link

@1510janu
Updated as per Issue mattermost#7428
639efad 
Updated as per Issue mattermost#7428

Added:
1. A bullet point under section - 'Log in using the desktop app'   2. 'Desktop App displays white screen while launching and doesn't load the page' under the section - 'Troubleshooting your Desktop App installation'.
@mattermost-build
Copy link
Contributor

Hello @1510janu,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cwarnermm cwarnermm self-requested a review October 2, 2024 12:21
@cwarnermm cwarnermm added the 2: Editor Review Requires review by an editor label Oct 2, 2024
@cwarnermm cwarnermm added the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Newest code from 1510janu has been published to preview environment for Git SHA f1956c0

@toninis toninis added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Newest code from 1510janu has been published to preview environment for Git SHA 1fb739a

@cwarnermm cwarnermm self-requested a review October 2, 2024 15:09
cwarnermm
cwarnermm approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @1510janu!

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request Hacktoberfest-accepted and removed 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 2, 2024
@cwarnermm cwarnermm merged commit 1d17da0 into mattermost:master Oct 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor Hacktoberfest null Hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1510janu @mattermost-build @cwarnermm @toninis