Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated configuration settings documentation #7461

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

belkhoujaons
Copy link
Contributor

@belkhoujaons belkhoujaons commented Oct 8, 2024

Summary

Remove deprecated configuration setting from product documentation

Ticket Link

Fixes #7460

@mattermost-build
Copy link
Contributor

Hello @belkhoujaons,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@cwarnermm cwarnermm self-requested a review October 9, 2024 13:26
@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Newest code from belkhoujaons has been published to preview environment for Git SHA 0c6f524

@cwarnermm
Copy link
Member

Thanks, @belkhoujaons!!

Please also remove the following text from that page:

Mattermost Boards setting
--------------------------

*Removed in the Mattermost v8.0 release*

@belkhoujaons
Copy link
Contributor Author

Thanks, @belkhoujaons!!

Please also remove the following text from that page:

Mattermost Boards setting
--------------------------

*Removed in the Mattermost v8.0 release*

done !

@cwarnermm
Copy link
Member

@belkhoujaons - Are you open to signing the Mattermost CLA? This step is required in order to merge your changes into the documentation code base.

Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @belkhoujaons!!

@belkhoujaons
Copy link
Contributor Author

@belkhoujaons - Are you open to signing the Mattermost CLA? This step is required in order to merge your changes into the documentation code base.

I just signed for that and it needs approval

@lindy65 lindy65 self-assigned this Oct 9, 2024
@cwarnermm
Copy link
Member

@belkhoujaons - Please comment in this PR with /check-cla and confirm that the CLA check is green. If it isn't, I'll investigate further.

@belkhoujaons
Copy link
Contributor Author

/check-cla

@Rutam21
Copy link
Contributor

Rutam21 commented Oct 11, 2024

@lindy65 You can assign this to me for QA Testing. Thanks.

@Rutam21
Copy link
Contributor

Rutam21 commented Oct 12, 2024

@cwarnermm Please generate another preview environment so that it includes the latest commits in the PR. Thanks.

@lindy65 lindy65 added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 13, 2024
@lindy65
Copy link
Contributor

lindy65 commented Oct 13, 2024

Assigned to you @Rutam21 and kicked off a new preview environment

Copy link

Newest code from belkhoujaons has been published to preview environment for Git SHA a30db42

@lindy65 lindy65 added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 15, 2024
Copy link

Newest code from belkhoujaons has been published to preview environment for Git SHA 54eba32

@Rutam21
Copy link
Contributor

Rutam21 commented Oct 15, 2024

The changes in this PR have been tested in the preview environment and all the required updates are available in the mentioned pages.

  • The Mattermost Board Settings section doesn't show up on the Deprecated Configuration Settings page on the Docs Site.
  • The Mattermost Board Settings link doesn't show up on the top of this page and is removed from the table of contents.
  • Searching for the Mattermost Board Settings or Enable publicly-shared boards doesn't return a result in the Additional Information section that points to this removed section.

I've attached a video as a confirmation.

PR-7461.QA.Testing.mp4

cc: @lindy65

@lindy65
Copy link
Contributor

lindy65 commented Oct 16, 2024

Thanks for testing @Rutam21 - counted towards Hacktoberfest!

cc @cwarnermm

@lindy65 lindy65 added QA-done QA review is complete and removed QA-wanted labels Oct 16, 2024
@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 16, 2024
@cwarnermm cwarnermm merged commit 800452d into mattermost:master Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor Hacktoberfest null QA-done QA review is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Wanted: Remove deprecated configuration setting from product documentation
5 participants