-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update share-links.rst #7481
Update share-links.rst #7481
Conversation
I added deep link configuration, the value and a few URL examples to for better clarity.
Hello @Good-Soma, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
Hello, |
/check-cla |
Okay, it has work. |
Newest code from Good-Soma has been published to preview environment for Git SHA 7c6b6a9 |
Newest code from Good-Soma has been published to preview environment for Git SHA efdf51c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Good-Soma. I've shortened your docs PR proposal for brevity, readability, and technical accuracy.
@lindy65 Please assign this PR to me for QA Testing. Thanks. |
Assigned to you @Rutam21 |
Newest code from Good-Soma has been published to preview environment for Git SHA efdf51c |
Okay, thanks I have seen it, plus my flaw, I will make the next document I will be working on better . Notify me, if you want me to make further changes? |
The changes in this PR have been tested in the preview environment and all the required changes are available in the mentioned pages.
I've attached a video as confirmation. PR-7481.QA.Testing.mp4cc: @lindy65 |
Thanks @Rutam21 - counted towards Hacktoberfest! cc @cwarnermm |
Fixes
I added a passage that describe how deep link can be formatted, it value with an example that clarify the message as a subsection in share-links.rst file as you instructed.
I made the content to correlate with the previous note that had been written.
Summary
Ticket Link