Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update share-links.rst #7481

Merged
merged 11 commits into from
Oct 17, 2024
Merged

Update share-links.rst #7481

merged 11 commits into from
Oct 17, 2024

Conversation

Good-Soma
Copy link
Contributor

Fixes

I added a passage that describe how deep link can be formatted, it value with an example that clarify the message as a subsection in share-links.rst file as you instructed.

I made the content to correlate with the previous note that had been written.

Summary

Ticket Link

I added deep link configuration,  the value and a few URL examples to for better clarity.
@mattermost-build
Copy link
Contributor

Hello @Good-Soma,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@Good-Soma
Copy link
Contributor Author

Hello,
I just sent a pull request that address the #7430 issue. Please, review it and merge it, if is okay, or notify me if I need to make any modification. Thanks

@Good-Soma
Copy link
Contributor Author

Hello @Good-Soma,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

/check-cla
I have signed the CLA in the website that I was directed to, but the check isn't turning green. I click on the detail beside the required box it showed, and downloaded the file in it, I wasn't able to open the file. Any hint?

@Good-Soma
Copy link
Contributor Author

Okay, it has work.

@cwarnermm cwarnermm self-requested a review October 15, 2024 15:08
@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 15, 2024
Copy link

Newest code from Good-Soma has been published to preview environment for Git SHA 7c6b6a9

source/collaborate/share-links.rst Outdated Show resolved Hide resolved
source/collaborate/share-links.rst Outdated Show resolved Hide resolved
source/collaborate/share-links.rst Outdated Show resolved Hide resolved
source/collaborate/share-links.rst Outdated Show resolved Hide resolved
source/collaborate/share-links.rst Outdated Show resolved Hide resolved
source/collaborate/share-links.rst Outdated Show resolved Hide resolved
@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 16, 2024
Copy link

Newest code from Good-Soma has been published to preview environment for Git SHA efdf51c

@cwarnermm cwarnermm self-requested a review October 16, 2024 14:55
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Good-Soma. I've shortened your docs PR proposal for brevity, readability, and technical accuracy.

@cwarnermm cwarnermm added QA-wanted and removed 2: Editor Review Requires review by an editor labels Oct 16, 2024
@Rutam21
Copy link
Contributor

Rutam21 commented Oct 16, 2024

@lindy65 Please assign this PR to me for QA Testing. Thanks.

@lindy65
Copy link
Contributor

lindy65 commented Oct 16, 2024

Assigned to you @Rutam21

@lindy65 lindy65 self-assigned this Oct 16, 2024
@lindy65 lindy65 added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 16, 2024
Copy link

Newest code from Good-Soma has been published to preview environment for Git SHA efdf51c

@Good-Soma
Copy link
Contributor Author

Thanks, @Good-Soma. I've shortened your docs PR proposal for brevity, readability, and technical accuracy.

Okay, thanks I have seen it, plus my flaw, I will make the next document I will be working on better . Notify me, if you want me to make further changes?

@Rutam21
Copy link
Contributor

Rutam21 commented Oct 16, 2024

The changes in this PR have been tested in the preview environment and all the required changes are available in the mentioned pages.

  • The new Deep Links section has been added to the Share links to channels and messages page.
  • This section is also listed in the list of contents on the right side of the page.

I've attached a video as confirmation.

PR-7481.QA.Testing.mp4

cc: @lindy65

@lindy65
Copy link
Contributor

lindy65 commented Oct 17, 2024

Thanks @Rutam21 - counted towards Hacktoberfest!

cc @cwarnermm

@lindy65 lindy65 added QA-done QA review is complete and removed QA-wanted labels Oct 17, 2024
@cwarnermm cwarnermm merged commit 9af8d96 into mattermost:master Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Hacktoberfest null preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories QA-done QA review is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants