Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-7454: Document New Youtube Referrer Policy Server Configuration Setting #7482

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Oct 15, 2024

Summary

This PR adds a YouTube Referrer Policy section in the Experimental Configuration Settings page with the necessary configuration setting options available to the users.

Ticket Link

Fixes #7454

  • This PR follows the Mattermost Contributing Guidelines.

@mattermost-build
Copy link
Contributor

Hello @Rutam21,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 15, 2024

@cwarnermm Please review and suggest changes, if any. Thanks.

@cwarnermm cwarnermm self-requested a review October 15, 2024 13:59
@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 15, 2024
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA 7e57193

@cwarnermm cwarnermm self-requested a review October 15, 2024 14:11
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Rutam21!!

@cwarnermm cwarnermm added QA-wanted and removed 2: Editor Review Requires review by an editor labels Oct 15, 2024
@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 15, 2024

@lindy65 You can assign this PR to me for QA Testing. Thanks.

@lindy65
Copy link
Contributor

lindy65 commented Oct 15, 2024

Assigned to you @Rutam21 :)

@lindy65 lindy65 added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 15, 2024
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA 3be9b9d

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 15, 2024

The changes in this PR have been tested in the preview environment and the new section is available on the mentioned page.

  • The YouTube referrer policy section has been added to the Experimental configuration settings page in the correct place.
  • This section also appears in the search results when we use the search option on the Docs site.

I've attached a video as a confirmation.

PR-7482.QA.Testing.mp4

cc: @lindy65

@lindy65
Copy link
Contributor

lindy65 commented Oct 15, 2024

Thanks so much @Rutam21 - counted towards Hacktoberfest!

cc @cwarnermm

@lindy65 lindy65 added QA-done QA review is complete and removed QA-wanted labels Oct 15, 2024
@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 15, 2024
@cwarnermm cwarnermm merged commit 6547758 into mattermost:master Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor Hacktoberfest null QA-done QA review is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Wanted: Document New Server Configuration Setting
4 participants