Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing VPC ID on initial provision #1070

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

gabrieljackson
Copy link
Contributor

Kops clusters don't have their VPC ID stored in metadata the first time the cluster is provisioned. This change adds a direct lookup in those cases.

Fixes https://mattermost.atlassian.net/browse/CLD-8293

Handle missing VPC ID on initial provision

Kops clusters don't have their VPC ID stored in metadata the first
time the cluster is provisioned. This change adds a direct lookup
in those cases.
@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 26, 2024
@gabrieljackson gabrieljackson marked this pull request as ready for review August 27, 2024 13:20
@gabrieljackson gabrieljackson added the kind/bug Categorizes issue or PR as related to a bug. label Aug 27, 2024
Copy link
Contributor

@stafot stafot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrieljackson gabrieljackson added the 4: Reviews Complete All reviewers have approved the pull request label Aug 28, 2024
@gabrieljackson gabrieljackson merged commit c613cb5 into master Aug 28, 2024
5 checks passed
@gabrieljackson gabrieljackson deleted the handle-missing-vpc-id branch August 28, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants