Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add second key to thanos-objstore-config in order to unify secrets but be BC at the same time keeping the old one #1072

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

stafot
Copy link
Contributor

@stafot stafot commented Sep 11, 2024

Summary

Add second key to thanos-objstore-config in order to unify secrets but be BC at the same time keeping the old one

Ticket Link

https://mattermost.atlassian.net/browse/CLD-7923

Release Note

Add second key to thanos-objstore-config in order to unify secrets but be BC at the same time keeping the old one

…t be BC at the same time keeping the old one

Signed-off-by: Stavros Foteinopoulos <[email protected]>
@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 11, 2024
@stafot stafot added 2: Dev Review Requires review by a developer 2: Infra Review Requires review by a SRE kind/refactor Categorizes issue or PR as related to refactor of production code. labels Sep 11, 2024
Copy link
Contributor

@andrleite andrleite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me add it for unmanaged utilities too.

@stafot stafot added the 4: Reviews Complete All reviewers have approved the pull request label Sep 12, 2024
@stafot stafot merged commit 2933ccd into master Sep 12, 2024
5 checks passed
@stafot stafot deleted the CLD-7923 branch September 12, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a developer 2: Infra Review Requires review by a SRE 4: Reviews Complete All reviewers have approved the pull request kind/refactor Categorizes issue or PR as related to refactor of production code. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants