Add project_id to Android sign script #967
Conversation
|
Newest code from enahum has been published to preview environment for Git SHA 88cbc6b |
1 similar comment
|
Newest code from enahum has been published to preview environment for Git SHA 88cbc6b |
|
OOOO... nice fix for the I'll download this, sign an unsigned bundle, and test... I've done it once, but will use the published version to QA this. |
|
Okay, test checks out. Only question I have is how do we handle the fact that the I can't see a way for firebase to provide this? Is it possible we could just form the |
|
That is probably a good idea |
|
I will take a stab at this. I'm still puzzled about why we don't get the Although, now that I think about it, if the full end to end build process still works then maybe the Google Services Maven plugin has already been updated to handle this 🤷🏼♂️? |
|
Newest code from sadohert has been published to preview environment for Git SHA b53ed52 |
| PROJECT_NUMBER=$(echo "$GOOGLE_SERVICES" | jq -r .project_info.project_number) | ||
| FIREBASE_URL=$(echo "$GOOGLE_SERVICES" | jq -r .project_info.firebase_url) | ||
| FIREBASE_URL="https://$PROJECT_ID.firebaseio.com" | ||
| echo "Setting FIREBASE_URL to: $FIREBASE_URL" |
There was a problem hiding this comment.
@sadohert maybe remove this echo ?
There was a problem hiding this comment.
I left the echo in as a bit of a breadcrumb in case the logic picked something up incorrectly.
|
Newest code from enahum has been published to preview environment for Git SHA 93322ec |
|
Newest code from hanzei has been published to preview environment for Git SHA 7e9c8ef |
|
Newest code from cwarnermm has been published to preview environment for Git SHA aa157f3 |
|
@sadohert - Friendly ping on this PR. Please note that a second reviewer is required for this repository. |
|
Hey - Apologies.. I didnt' know I still had to do something here. @enahum how relevant is all this with Gekidou? |
|
Newest code from cwarnermm has been published to preview environment for Git SHA 0bd8548 |
|
Newest code from cwarnermm has been published to preview environment for Git SHA 85b8cad |
|
Newest code from cwarnermm has been published to preview environment for Git SHA 54831c5 |
|
Newest code from cwarnermm has been published to preview environment for Git SHA 813ef90 |
|
@sadohert - Friendly reminder to review this PR. Thanks! |
|
Newest code from cwarnermm has been published to preview environment for Git SHA f14c8b0 |
|
@cwarnermm I'm not likely to get to this for a while, but I also don't want to lose the change if it comes up again with another customer (hard to know when this will rear its head).... is there a place this PR can sit that isn't in the way, but isn't gone for good? |
|
Happy to leave it right here and open, @sadohert. |
|
Newest code from cwarnermm has been published to preview environment for Git SHA 82f017a |
hanzei
added
Lifecycle/frozen
and removed
1: Dev Review
|
Newest code from hanzei has been published to preview environment for Git SHA 1032b94 |
Summary
Added project_id to be replaced in the strings resources as is needed by Firebase Cloud Messaging to be able to initialize and retrieve the device token to receive notifications.