Scheduled post Actions #8603

Rajat-Dabade · 2025-02-18T11:20:29Z

Summary

Ticket Link

Checklist

Added or updated unit tests (required for all new features)
Has UI changes
Includes text changes and localization file updates
Have tested against the 5 core themes to ensure consistency between them.
Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on:

Screenshots

Release Note

harshilsharma63

LGTM!

larkox

Some comments to address, but in general it looks good.

app/utils/scheduled_post/scheduled_post.test.ts

app/utils/scheduled_post/index.ts

app/utils/scheduled_post/scheduled_post.test.ts

app/screens/draft_scheduled_post_options/draft_scheduled_post_options.test.tsx

app/components/post_draft/send_handler/__tests__/send_handler.test.tsx

larkox

A few more things to look at in the tests.

app/utils/scheduled_post/scheduled_post.test.ts

app/screens/reschedule_draft/reschedule_draft.tsx

app/screens/reschedule_draft/reschedule_draft.test.tsx

app/components/post_draft/send_handler/send_handler.test.tsx

larkox · 2025-02-26T15:18:01Z

app/components/post_draft/send_handler/send_handler.test.tsx

+        // Mock implementation to capture the sendMessageHandler
+        let capturedHandler: Function;
+        (sendMessageWithAlert as jest.Mock).mockImplementation((params) => {
+            capturedHandler = params.sendMessageHandler;


(Personal opinion) This is one way to do it, but I think it is more elegant to inspect the mock calls instead of trying to set this variable. 0/5.

app/components/post_draft/send_handler/send_handler.test.tsx

enahum · 2025-02-26T01:38:14Z

app/screens/reschedule_draft/reschedule_draft.tsx

+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, []);
+
+    const toggleSaveButton = useCallback(preventDoubleTap((enabled = true) => {


There is a hook called usePreventDoubleTap, use that one instead

enahum · 2025-02-26T01:38:59Z

app/screens/reschedule_draft/reschedule_draft.tsx

+        }
+    }, [intl, onClose]);
+
+    const onSavePostMessage = useCallback(async () => {


Should have the prevent double tap has well, no?

larkox

LGTM! A couple more comments, but really minor things.

larkox · 2025-02-27T15:31:01Z

app/screens/draft_scheduled_post_options/rescheduled_draft.test.tsx

+
+    it('calls dismissBottomSheet and showModal when pressed', async () => {
+        // Mock implementation to resolve immediately
+        (dismissBottomSheet as jest.Mock).mockResolvedValue(undefined);


One last jest.Mock.

larkox · 2025-02-27T15:33:27Z

app/utils/scheduled_post/scheduled_post.test.ts

+        cancelButton.onPress?.();
+
+        // Verify swipeable close is called
+        expect(baseProps.swipeable?.current?.close).toHaveBeenCalled();


Would be nice to verify the delete has not been called in this scenario.

larkox · 2025-02-27T15:36:59Z

app/utils/scheduled_post/scheduled_post.test.ts

+        const buttons = alertMock.mock.calls[0]?.[2] ?? []; // Ensure buttons array exists
+        const cancelButton = buttons[0];
+        expect(cancelButton).toBeDefined();
+        const onPress = cancelButton.onPress ?? (() => {});


This is weird. If the ?? (() => {}) part is just to keep typescript happy, you can use the non-null assertion operator (! the exclamation mark) to tell TS that you are sure it is never going to be undefined.

The non-null assertion operator is dangerous and should be used scarcely, but in this scenario should be fine.

larkox · 2025-02-27T15:44:13Z

app/screens/reschedule_draft/reschedule_draft.test.tsx

+        // Check that the component registered with proper navigation handler
+        const registerCall = jest.mocked(Navigation.events().registerComponentListener).mock.calls[0][0];
+        expect(registerCall).toBeDefined();
+        expect(registerCall.navigationButtonPressed).toBeDefined();


We check it exist. Do we want to check if it does what it has to do? I would expect something similar to what you have in the last test of this file, but also for other buttons (not only the close one).

Added what happens when it clicked on save button.

larkox · 2025-02-27T15:45:32Z

app/screens/reschedule_draft/reschedule_draft.test.tsx

+        const setButtonsMock = jest.mocked(setButtons);
+        const mockCalls = setButtonsMock.mock.calls;
+
+        const lastCallIndex = mockCalls.length - 1;


You can clear the mocks (setButtonsMock.clearMocks) before performing the action that will trigger this.

If there are more than one call because of executing the action, could mean you are calling it more than needed.

larkox · 2025-02-27T15:52:28Z

app/screens/draft_scheduled_post_options/rescheduled_draft.test.tsx

+import {Screens} from '@constants';
+import {dismissBottomSheet, showModal} from '@screens/navigation';
+import {renderWithIntlAndTheme} from '@test/intl-test-helper';
+import test_helper from '@test/test_helper';


Import this as TestHelper, please.

larkox · 2025-02-27T15:55:48Z

app/components/post_draft/send_handler/send_handler.test.tsx

+        const draftInput = wrapper.getByTestId('test_send_handler');
+        expect(draftInput).toBeTruthy();
+        const priority = wrapper.getByText('URGENT');
+        expect(priority).toBeTruthy();


0/5 for simplicity

Suggested change

const draftInput = wrapper.getByTestId('test_send_handler');

expect(draftInput).toBeTruthy();

const priority = wrapper.getByText('URGENT');

expect(priority).toBeTruthy();

expect( wrapper.getByTestId('test_send_handler')).toBeTruthy();

expect(wrapper.getByText('URGENT')).toBeTruthy();

enahum · 2025-03-11T02:50:01Z

app/screens/reschedule_draft/reschedule_draft.tsx

+    body: {
+        flex: 1,
+    },
+    container: {
+        flex: 1,
+    },


there is no point of having two styles that do the same.. keep one, remove the other one

enahum · 2025-03-11T02:51:04Z

app/screens/reschedule_draft/reschedule_draft.tsx

+import Loading from '@components/loading';
+import {useServerUrl} from '@context/server';
+import {useTheme} from '@context/theme';
+import DatabaseManager from '@database/manager';


this looks very wrong here

enahum · 2025-03-11T02:51:31Z

app/screens/reschedule_draft/reschedule_draft.tsx

+    const theme = useTheme();
+    const intl = useIntl();
+    const serverUrl = useServerUrl();
+    const {database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);


this can throw an error and crash the entire thing

Moved it to updateSchedulePost function.

enahum · 2025-03-11T02:53:09Z

app/screens/reschedule_draft/reschedule_draft.tsx

+            setErrorLine(errorMessage);
+            return;
+        }
+        const draftPayload = await draft.toApi(database);


consider doing this at updateSchedulePost action instead of doing it here, you can allow the two types as the draftPayload argument and check the type, convert if needed.

app/screens/reschedule_draft/reschedule_draft.tsx

enahum

Not a blocker but you should use the correct type instead of any

enahum · 2025-03-13T08:28:47Z

app/utils/scheduled_post/index.ts

+    );
+}
+
+export const isScheduledPostModel = (obj: any): obj is ScheduledPostModel =>


Since this is a guard, instead of any, it is more idiomatic to use "unknown".

That being said, that is to verify it is a scheduled post model from any kind of object (for example, the result of a JSON.parse). The body of this function doesn't seem to do that, so I guess it will be used to distinguish from the "api" version of a scheduled post and the "model version" of a scheduled post. If that is the case, it makes sense to have it typed as such (i.e. (obj: ScheduledPostModel | ScheduledPost): obj is ScheduledPostModel)

mm-cloud-bot added the release-note label Feb 18, 2025

Rajat-Dabade force-pushed the scheduled-post-options branch 2 times, most recently from ad1c32e to 10b0d66 Compare February 21, 2025 09:05

Rajat-Dabade force-pushed the list-scheduled-post branch 2 times, most recently from de2b148 to 3a6f367 Compare February 21, 2025 09:15

Rajat-Dabade force-pushed the scheduled-post-options branch 2 times, most recently from cd6e159 to 2bd8672 Compare February 21, 2025 09:39

Rajat-Dabade requested review from larkox, harshilsharma63 and enahum February 21, 2025 09:47

Rajat-Dabade self-assigned this Feb 21, 2025

Rajat-Dabade added the 2: Dev Review Requires review by a core commiter label Feb 21, 2025

Rajat-Dabade marked this pull request as ready for review February 21, 2025 09:47

harshilsharma63 approved these changes Feb 21, 2025

View reviewed changes

larkox requested changes Feb 24, 2025

View reviewed changes

Rajat-Dabade force-pushed the list-scheduled-post branch from 68bf2da to 63d31e5 Compare February 25, 2025 09:41

Rajat-Dabade added 9 commits February 25, 2025 17:37

updated test

5cfe4ff

Scheduled post Actions

59b2512

Added test for app/utils/scheduled_post/index.ts

cf8652b

Added test for app/screens/draft_scheduled_post_options/delete_draft.tsx

18f8430

Updated test Id for rescheduled draft

3d4f998

added test from send delete and draft scheduled post options

6c1d2c4

Added test for reschedule_draft

931a817

Added test for SendHandle

2c2bfb6

Imported fixes and removed unnecessary types

5517875

Rajat-Dabade force-pushed the scheduled-post-options branch from 2bd8672 to 5517875 Compare February 25, 2025 12:14

Rajat-Dabade added 2 commits February 25, 2025 23:24

Test fix for Scheduled post rmeote handler

dd6a781

Addressed review comments

f3d109d

Rajat-Dabade requested a review from larkox February 26, 2025 07:24

larkox requested changes Feb 26, 2025

View reviewed changes

Addressed some review comments

8401677

enahum requested changes Feb 26, 2025

View reviewed changes

Rajat-Dabade added 2 commits February 27, 2025 00:35

Addressed some review comments

a890381

updated test

8774b2b

Rajat-Dabade requested review from enahum and larkox February 26, 2025 19:48

larkox approved these changes Feb 27, 2025

View reviewed changes

enahum requested changes Mar 11, 2025

View reviewed changes

Rajat-Dabade added 2 commits March 12, 2025 16:54

addressed review comments

a16240e

update test

3b735f2

Rajat-Dabade requested a review from enahum March 12, 2025 13:17

enahum approved these changes Mar 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scheduled post Actions #8603

Scheduled post Actions #8603

Rajat-Dabade commented Feb 18, 2025

harshilsharma63 left a comment

larkox left a comment

larkox left a comment

larkox Feb 26, 2025

enahum Feb 26, 2025

Rajat-Dabade Feb 26, 2025

enahum Feb 26, 2025

Rajat-Dabade Feb 26, 2025

larkox left a comment

larkox Feb 27, 2025

Rajat-Dabade Mar 12, 2025

larkox Feb 27, 2025

Rajat-Dabade Mar 12, 2025

larkox Feb 27, 2025

larkox Feb 27, 2025

Rajat-Dabade Mar 12, 2025

larkox Feb 27, 2025

Rajat-Dabade Mar 12, 2025

larkox Feb 27, 2025

Rajat-Dabade Mar 12, 2025

larkox Feb 27, 2025

Rajat-Dabade Mar 12, 2025

enahum Mar 11, 2025

enahum Mar 11, 2025

enahum Mar 11, 2025

Rajat-Dabade Mar 12, 2025

enahum Mar 11, 2025

enahum left a comment

enahum Mar 13, 2025

larkox Mar 13, 2025

Scheduled post Actions #8603

Are you sure you want to change the base?

Scheduled post Actions #8603

Conversation

Rajat-Dabade commented Feb 18, 2025

Summary

Ticket Link

Checklist

Device Information

Screenshots

Release Note

harshilsharma63 left a comment

Choose a reason for hiding this comment

larkox left a comment

Choose a reason for hiding this comment

larkox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

larkox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

enahum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment