Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update additional images branding #8672

Open
wants to merge 4 commits into
base: update-empty-state-images
Choose a base branch
from

Conversation

marianunez
Copy link
Member

@marianunez marianunez commented Mar 13, 2025

Summary

Another set of new branding images updates:

  • App review modal image
  • Loading error image
  • Drafts empty state

Ticket Link

Checklist

  • [ ] Added or updated unit tests (required for all new features)
  • Has UI changes
  • [ ] Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Screenshots

Screenshot 2025-03-12 at 9 18 49 PM Screenshot 2025-03-12 at 8 39 57 PM Screenshot 2025-03-12 at 11 41 09 AM

Release Note

None

@marianunez marianunez changed the base branch from main to update-empty-state-images March 13, 2025 01:22
import {useTheme} from '@context/theme';
import {changeOpacity, makeStyleSheetFromTheme} from '@utils/theme';
import {typography} from '@utils/typography';

const draft_message_image = require('@assets/images/Draft_Message.png');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the asset if no longer used :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't even finished the PR description 🤣

@marianunez marianunez added 2: Dev Review Requires review by a core commiter 2: UX Review Requires review by a UX Designer labels Mar 13, 2025
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we have a new image for the empty scheduled post as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core commiter 2: UX Review Requires review by a UX Designer release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants