Adapt to RHS scroll direction change #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crspeller
force-pushed
the
upside-down-rhs
branch
from
23e0ade
to
993690a
Compare
jespino
reviewed
Aug 13, 2024
| top: 50%; | ||
| transform: translate(-50%, -50%); | ||
| }`} | ||
| const PostBody = styled.div` |
There was a problem hiding this comment.
0/5 here, I see the value on giving a name to the div itself, but maybe, because it is no longer needed from the styles perspective we can remove this. Anyway, I'm ok leaving it as is, just to give it a name.
There was a problem hiding this comment.
The name is helpful for debugging and whatnot I think we can leave it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt to PR in webapp changing RHS scroll direction: mattermost/mattermost#27162
Also requires mattermost/mattermost#27871 so scrolling doesn't break for generating posts.