[MM-45894] Allow signaling through data channel #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
This was referenced Sep 24, 2024
cpoile
approved these changes
Sep 30, 2024
cpoile
added
3: Reviews Complete
* Replace pako with faster fflate * Mitigate signaling race * Update dependencies * Fix jest * [MM-60561] RTC client metrics (#874) * lt: add incoming track handler * Enable RTC monitor in lt client * Update dependencies * Update server mocks * Bump dependencies
streamer45
removed
the
Do Not Merge/Awaiting PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On this side, the change is minimal. We are simply adding the new
EnableDCSignalingconfig setting and making sure it's forwarded to rtcd.Note: still on my TODO to apply the changes on mobile. Just waiting to test this a bit first.
Related PRs
mattermost/calls-common#39
mattermost/rtcd#156
Ticket Link
https://mattermost.atlassian.net/browse/MM-45894