Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e pipeline flakyness #867

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix e2e pipeline flakyness #867

merged 1 commit into from
Sep 25, 2024

Conversation

streamer45
Copy link
Collaborator

Summary

Printing calls-recorder/transcriber logs have been often failing as of late with Error response from daemon: can not get logs from container which is dead or marked for removal.

We only really care about exited containers, which are retained past their execution. Ideally we'd filter by exit code but the docker ps filter functionality doesn't seem to support advanced logic such as exited!=0.

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Sep 25, 2024
@streamer45 streamer45 self-assigned this Sep 25, 2024
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pretty advanced logic.
I'm sure you've checked if there's another way that it does support?

@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 25, 2024
@streamer45
Copy link
Collaborator Author

That's pretty advanced logic. I'm sure you've checked if there's another way that it does support?

@cpoile You can filter by exit code but what we need is anything but 0 (success). With some advanced scripting we could compare the two lists (all containers and those exited with 0) and find the difference, but that's overkill. If we get more failures I'll simply get rid of the logs since they are only used to debug.

@streamer45 streamer45 merged commit 72cd104 into main Sep 25, 2024
19 checks passed
@streamer45 streamer45 deleted the fix-flakyness branch September 25, 2024 20:25
streamer45 added a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants