DC messages #870
Merged
DC messages #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
streamer45
commented
Oct 2, 2024
Comment on lines
+471
to
+474
| // Waiting a second before transmitting to avoid | ||
| // the known race between incoming and outgoing track. | ||
| // This is needed as pion doesn't support perfect negotiation yet. | ||
| time.Sleep(time.Second) |
There was a problem hiding this comment.
Using DC further exacerbated the impact of signaling conflicts, so I had to add this to make it usable. Browsers are not affected as they support perfect negotiation (SDP rollback).
cpoile
approved these changes
Oct 9, 2024
Comment on lines
+471
to
+474
| // Waiting a second before transmitting to avoid | ||
| // the known race between incoming and outgoing track. | ||
| // This is needed as pion doesn't support perfect negotiation yet. | ||
| time.Sleep(time.Second) |
| @@ -5,8 +5,7 @@ import type {EmojiData, CallsClientJoinData} from '@mattermost/calls-common/lib/ | |||
|
|
|||
| import {EventEmitter} from 'events'; | |||
|
|
|||
| // @ts-ignore | |||
| import {deflate} from 'pako/lib/deflate'; | |||
| import {zlibSync, strToU8} from 'fflate'; | |||
There was a problem hiding this comment.
My own interest, why this change?
There was a problem hiding this comment.
@cpoile It's ~40% faster, proper typescript and 5 times smaller bundle size. It got me convinced.
streamer45
added
3: Reviews Complete
* lt: add incoming track handler * Enable RTC monitor in lt client * Update dependencies * Update server mocks * Bump dependencies
streamer45
removed
the
Do Not Merge/Awaiting PR
streamer45
added a commit
that referenced
this pull request
Oct 9, 2024
* Allow signaling through data channel * Update i18n * Update calls-common * DC messages (#870) * Replace pako with faster fflate * Mitigate signaling race * Update dependencies * Fix jest * [MM-60561] RTC client metrics (#874) * lt: add incoming track handler * Enable RTC monitor in lt client * Update dependencies * Update server mocks * Bump dependencies * Update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Not much of a change on this side. I removed the
pakodependency since we now usefflate. Also reworked logging and updated dependencies.Related PRs
mattermost/rtcd#158
mattermost/calls-common#40