Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation restart button to UI #148

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

gabrieljackson
Copy link
Contributor

The button provides an easy way to restart Mattermost server instances. A confirmation modal is presented before the restart is kicked off.

Fixes https://mattermost.atlassian.net/browse/CLD-6789

Add installation restart button to UI

The button provides an easy way to restart Mattermost server
instances. A confirmation modal is presented before the restart
is kicked off.
@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 8, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (507cc0d) 46.15% compared to head (49d67ff) 46.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   46.15%   46.15%           
=======================================
  Files          24       24           
  Lines        2186     2186           
=======================================
  Hits         1009     1009           
  Misses       1060     1060           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabrieljackson gabrieljackson marked this pull request as ready for review January 8, 2024 20:12
@gabrieljackson gabrieljackson added the 2: Dev Review Requires review by a core committer label Jan 8, 2024
Copy link
Contributor

@nickmisasi nickmisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing to look at but otherwise LGTM!

Copy link
Contributor

@nickmisasi nickmisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good reuse of the confirmation modal

@gabrieljackson gabrieljackson added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 9, 2024
@gabrieljackson gabrieljackson merged commit 3b0dfc4 into master Jan 9, 2024
5 checks passed
@gabrieljackson gabrieljackson deleted the restart-button branch January 9, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants