Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add messageswillbeconsumed hook demo #168

Conversation

topolovac
Copy link
Contributor

@topolovac topolovac commented Oct 26, 2023

Adding MessagesWillBeConsumed hook demo.
Hook was recently merged into master with this PR: mattermost/mattermost#23305

Tagging @qryptdev

@topolovac topolovac requested a review from hanzei as a code owner October 26, 2023 16:04
@mattermost-build
Copy link
Contributor

Hello @topolovac,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 1.98%. Comparing base (4720c03) to head (eea0812).
Report is 1 commits behind head on master.

❗ Current head eea0812 differs from pull request most recent head f2c1d9b. Consider uploading reports for the commit f2c1d9b to get more accurate results

Files Patch % Lines
server/message_hooks.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #168      +/-   ##
=========================================
- Coverage    3.09%   1.98%   -1.12%     
=========================================
  Files          15      14       -1     
  Lines        1872    1817      -55     
=========================================
- Hits           58      36      -22     
+ Misses       1812    1779      -33     
  Partials        2       2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @topolovac,

Thanks for your contribution 🎉 Would you be open to signing the CLA as mentioned in #168 (comment)? After that, I'm happy to review your PR. Thanks!

@topolovac
Copy link
Contributor Author

/check-cla

@hanzei
Copy link
Contributor

hanzei commented Oct 27, 2023

LGTM 👍

@hanzei hanzei requested a review from lieut-data October 27, 2023 09:54
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks @topolovac!

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Nov 1, 2023
@hanzei hanzei requested a review from saturninoabril November 1, 2023 12:02
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@saturninoabril
Copy link
Member

/update-branch

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay and thanks @topolovac for your contribution!

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed Lifecycle/frozen 3: QA Review Requires review by a QA tester labels Apr 25, 2024
@saturninoabril saturninoabril merged commit abc605f into mattermost:master Apr 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants