-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add messageswillbeconsumed hook demo #168
Feature/add messageswillbeconsumed hook demo #168
Conversation
Hello @topolovac, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #168 +/- ##
=========================================
- Coverage 3.09% 1.98% -1.12%
=========================================
Files 15 14 -1
Lines 1872 1817 -55
=========================================
- Hits 58 36 -22
+ Misses 1812 1779 -33
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @topolovac,
Thanks for your contribution 🎉 Would you be open to signing the CLA as mentioned in #168 (comment)? After that, I'm happy to review your PR. Thanks!
/check-cla |
LGTM 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, thanks @topolovac!
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
/update-branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay and thanks @topolovac for your contribution!
Adding MessagesWillBeConsumed hook demo.
Hook was recently merged into master with this PR: mattermost/mattermost#23305
Tagging @qryptdev