-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example usage of outgoing webhooks #171
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #171 +/- ##
=========================================
+ Coverage 2.93% 3.10% +0.16%
=========================================
Files 14 15 +1
Lines 1838 1869 +31
=========================================
+ Hits 54 58 +4
- Misses 1782 1809 +27
Partials 2 2 ☔ View full report in Codecov by Sentry. |
/update-branch |
@hanzei I have a bit of a silly problem. I can't get the build for this. Perhaps more important than whatever is happening on my local... I see the pipeline can build it just fine but I don't know how to go get the artifact. Has this UI changed? Please let me know if you can provide some guidance. |
Can you please run |
@hanzei I may ned help on this again. I see an error when it tries to fire the hook.
Please advise what I may be missing here. It's not clear to me what value stats with |
@hanzei I tried this again but still no luck. I made a valid outgoing webhook to a server running locally and the demo plugin did not do anything. Which is probably expected. I also read the documentation updates and you provided and pointed the hook to Let me know if you have any suggestions. |
@DHaussermann Can you please share a screenshot of settings that your Outgoing Webhook uses? |
@hanzei When I set this up again on a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
- Demo plugin now provided a mechanism for testing outgoing webhook that posts a response as expected
- Setup is documented.
- Delay setting in plugin config is respected.
- I ended up not needing the logging but I did try with an incorrect callback URL and confirmed and error clearly shows a failure for an outgoing webhook and provides details.
LGTM!
Huge thanks @hanzei this is a great enhancement that will help facilitate future testing! 🎉
Summary
Ticket Link
For mattermost/mattermost#23805