Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-611]: Added the feature to select the default repository for the channel #806

Merged
merged 10 commits into from
Jan 29, 2025

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Jul 17, 2024

Summary

Created the slash commands /github default-command get, set, and unset, to handle the default repo for channel per user. The default repo will be auto-filled in the create GitHub issue modal so the user won't need to search the repo everytime.

Ticket Link

Fixes #611

What to tests

  1. Run the commands /github default-command get, set, and unset and see if they are working properly or not.
  2. After setting the default repo, run the /github issue create command, it should open a modal with the default repo autoselected.

server/plugin/api.go Outdated Show resolved Hide resolved
server/plugin/api.go Outdated Show resolved Hide resolved
server/plugin/api.go Outdated Show resolved Hide resolved
server/plugin/api.go Outdated Show resolved Hide resolved
server/plugin/api.go Show resolved Hide resolved
server/plugin/command.go Outdated Show resolved Hide resolved
server/plugin/command.go Outdated Show resolved Hide resolved
server/plugin/command.go Outdated Show resolved Hide resolved
server/plugin/command.go Outdated Show resolved Hide resolved
server/plugin/command.go Outdated Show resolved Hide resolved
@raghavaggarwal2308 raghavaggarwal2308 self-requested a review August 6, 2024 07:33
server/plugin/api.go Outdated Show resolved Hide resolved
server/plugin/api.go Outdated Show resolved Hide resolved
server/plugin/api.go Outdated Show resolved Hide resolved
server/plugin/command.go Outdated Show resolved Hide resolved
server/plugin/command.go Outdated Show resolved Hide resolved
server/plugin/command.go Outdated Show resolved Hide resolved
server/plugin/command.go Outdated Show resolved Hide resolved
server/plugin/command.go Outdated Show resolved Hide resolved
server/plugin/command.go Outdated Show resolved Hide resolved
server/plugin/command.go Outdated Show resolved Hide resolved
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arush-vashishtha
Copy link

@Kshitij-Katiyar, I have tested this PR, and the slash commands to set, get, and unset the default repo are working fine. However, the issue create modal does not open upon using the " /GitHub issue create " command in the channels.

@Kshitij-Katiyar
Copy link
Contributor Author

@Kshitij-Katiyar, I have tested this PR, and the slash commands to set, get, and unset the default repo are working fine. However, the issue create modal does not open upon using the " /GitHub issue create " command in the channels.

@arush-vashishtha the issue has been fixed, please re-test the PR.

webapp/src/reducers/index.ts Outdated Show resolved Hide resolved
server/plugin/api.go Outdated Show resolved Hide resolved
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested for the code changes and the slash command to set, un-set and get the default repository set for the channel is working fine. Also, after setting the default repo, the modal opened for creating any issue shows the already repository in the modal, LGTM. Approved.

@raghavaggarwal2308 raghavaggarwal2308 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 29, 2025
@raghavaggarwal2308 raghavaggarwal2308 added this to the v2.4.0 milestone Jan 29, 2025
@raghavaggarwal2308 raghavaggarwal2308 merged commit 29da42c into master Jan 29, 2025
11 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-611 branch January 29, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Setting for Default Repository per Channel for Creating Issues
5 participants