Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-860]: Added message to delete webhook after subscription deletion #861

Merged
merged 1 commit into from
Jan 30, 2025
Merged

[MM-860]: Added message to delete webhook after subscription deletion #861

merged 1 commit into from
Jan 30, 2025

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

Added message to delete webhook after subscription deletion

Screenshots

Old

Screenshot from 2024-12-04 14-23-16

New

Screenshot from 2024-12-04 14-19-54

Ticket Link

Fixes #860

What to test
  • Create subscription
  • Unsubscribe and check the message and test the links

@Kshitij-Katiyar Kshitij-Katiyar added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Dec 4, 2024
@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Dec 4, 2024
@raghavaggarwal2308 raghavaggarwal2308 added this to the v2.4.0 milestone Dec 4, 2024
@raghavaggarwal2308 raghavaggarwal2308 removed the 2: Dev Review Requires review by a core committer label Dec 5, 2024
AayushChaudhary0001
AayushChaudhary0001 approved these changes Jan 30, 2025
View reviewed changes
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested and the code changes are working fine, the user is getting redirected to the webhook page where the user can delete the webhook. The support message of deleting the webhook also looks good, LGTM. Approved.

@raghavaggarwal2308 raghavaggarwal2308 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 30, 2025
@raghavaggarwal2308 raghavaggarwal2308 merged commit 6b2cd35 into master Jan 30, 2025
9 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-860 branch January 30, 2025 12:23
@AayushChaudhary0001 AayushChaudhary0001 mentioned this pull request Jan 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

Add message to delete the existing webook after deleting a subscription.
4 participants
@Kshitij-Katiyar @wiggin77 @raghavaggarwal2308 @AayushChaudhary0001