Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-61121] Add diagnostics data to the Support Packet #1131

Merged
merged 9 commits into from
Dec 10, 2024
Merged

[MM-61121] Add diagnostics data to the Support Packet #1131

merged 9 commits into from
Dec 10, 2024

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Oct 16, 2024 •
edited
Loading

Summary

When a Support Packet gets generated, the plugin now includes diagnostics data via a diagnostics.yaml file into the Packet.

Example content of jira/diagnostics.yaml:

version: 4.1.1-rc1+7536b5d
instance_count: 0
server_instance_count: 0
cloud_instance_count: 0
subscription_count: 0
connected_user_count: 0

Requires mattermost/mattermost#28833 on the server side

Ticket Link

https://mattermost.atlassian.net/browse/MM-61121

@hanzei hanzei added the Work In Progress Not yet ready for review label Oct 16, 2024
@hanzei hanzei force-pushed the MM-61121_support-packet branch from c0443ea to 7536b5d Compare October 16, 2024 13:19
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester and removed Work In Progress Not yet ready for review labels Nov 4, 2024
@hanzei hanzei marked this pull request as ready for review November 4, 2024 12:00
@hanzei hanzei requested a review from wiggin77 as a code owner November 4, 2024 12:00
@mattermost mattermost deleted a comment from mattermost-build Nov 4, 2024
wiggin77
wiggin77 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei
Copy link
Collaborator Author

hanzei commented Dec 4, 2024

@Kshitij-Katiyar Gentle reminder to review the PR 😉

Kshitij-Katiyar
Kshitij-Katiyar reviewed Dec 4, 2024
View reviewed changes
server/telemetry.go Outdated Show resolved Hide resolved
Kshitij-Katiyar
Kshitij-Katiyar reviewed Dec 4, 2024
View reviewed changes
server/telemetry.go Outdated Show resolved Hide resolved
Kshitij-Katiyar
Kshitij-Katiyar requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanzei Reviewed

Kshitij-Katiyar
Kshitij-Katiyar approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my side

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Dec 4, 2024
@hanzei
Copy link
Collaborator Author

hanzei commented Dec 10, 2024

Per discussion with @raghavaggarwal2308, QA testing will happen post-merge.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Dec 10, 2024
@hanzei hanzei added this to the v4.2.0 milestone Dec 10, 2024
@hanzei hanzei merged commit a8d2403 into master Dec 10, 2024
9 checks passed
@hanzei hanzei deleted the MM-61121_support-packet branch December 10, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kshitij-Katiyar Kshitij-Katiyar Kshitij-Katiyar approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hanzei @wiggin77 @Kshitij-Katiyar