Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCAL] Enable notifications and reminders when a superuser token is not supported #272
[GCAL] Enable notifications and reminders when a superuser token is not supported #272
Changes from 33 commits
4d3a2bb
fe6fe75
7634f2c
9dc21a2
a436769
18767a3
8de4223
af611a9
24c2c64
0ecad3f
165948c
2e6c571
cc88b2e
0def44a
c5f0e1c
0b7bce2
100497a
d90fb5e
4345953
57b30f9
92de736
3e3f43d
5c05a74
5dbc701
19abc70
c3336e9
e4f73fd
9951416
a92d545
c090410
ecca739
6f2b1d7
351730c
7c3b63d
d8745f6
58e7b9f
9aac20f
c9378ce
b139ac5
08b039e
b240b85
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible this could have side effects since this mutates state, and thus affects functions like
syncUsers
. From a quick look, it seems that it won't have issues though.What's weird is that the only client used in that path is in
GetCalendarViews
, which is setting its own user-level client for batch requests. Not sure how that is working this way:mattermost-plugin-mscalendar/server/mscalendar/availability.go
Lines 388 to 389 in d78381a