[GCAL] today/tomorrow commands with styling #273

fmartingr · 2023-07-27T08:17:53Z

Summary

Adds: /trigger summary today, /trigger summary tomorrow
Aliases: /trigger today, /trigger tomorrow.
Refactored GetDailySummaryForUser(user *User) (string, error) to GetDaySummaryForUser(now time.Time, user *User) (string, error) (allows sending the day, since the logic is the same).
Views: Added new RenderDaySummary which uses slack attachments to display each event (see screenshots below)
Poster: Added new DMWithMessageAndAttachments(mattermostUserID, message string, attachments ...*model.SlackAttachment) (string, error)

Ticket Link

Notes

I have not included the button because we can't directly add an URL in there, we need to add a handler. It also didn't make much sense since we have the link just above the button anyway. (Discussion pending)
The views could be interfaced to allow the users to select which view they prefect. Personally I like the table view, but having the option to choose is nice. I didn't want to spend time on that just yet.
The Poster cloud be improved by using a more generative approach: Example:Poster.DM(mattermostUserID, option.WithAttachments(attachments), options.WithMessage(message)).

Screenshots

codecov-commenter · 2023-07-27T08:20:57Z

Codecov Report

Patch coverage has no change and project coverage change: -0.08% ⚠️

Comparison is base (585e821) 15.29% compared to head (ed9d16b) 15.21%.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           migrate-to-gcal     #273      +/-   ##
===================================================
- Coverage            15.29%   15.21%   -0.08%     
===================================================
  Files                   78       78              
  Lines                 3780     3798      +18     
===================================================
  Hits                   578      578              
- Misses                3138     3156      +18     
  Partials                64       64

Files Changed	Coverage Δ
server/command/command.go	`35.53% <0.00%> (-1.86%)`	⬇️
server/command/daily_summary.go	`0.00% <0.00%> (ø)`
server/mscalendar/daily_summary.go	`39.30% <0.00%> (-1.66%)`	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mickmister · 2023-07-28T16:44:32Z

Personally I like the table view, but having the option to choose is nice.

I have to agree 🙂 The attachments version is a little difficult to visually at a glance. I think a structured view like a table works better here. Are you able to post a screenshot of the table version for a before & after comparison?

0/5 on if it should be the table view, and/or have a toggle for this. @DHaussermann I'm curious what you think about this?

mickmister

Code LGTM 👍 Just a few comments

server/mscalendar/daily_summary.go

server/mscalendar/views/calendar.go

fmartingr · 2023-07-29T05:47:56Z

Table view

Attachment view

I believe in another PR i made the attachment titles links as well.

cc: @matthewbirtch

mickmister · 2023-07-31T08:48:34Z

Looking at the before & after (table vs attachment view), I definitely prefer the table view. I think the attachment view is good for showing one event's information, but not so much when trying to visually parse several events at once.

mickmister

LGTM, though I would like to see the table view supported for the daily summary. @matthewbirtch Do you have any thoughts on this?

jasonblais · 2023-07-31T13:07:18Z

Looking at the before & after (table vs attachment view), I definitely prefer the table view. I think the attachment view is good for showing one event's information, but not so much when trying to visually parse several events at once.

+1 for a table view for a more concise daily summary of events

matthewbirtch · 2023-07-31T13:17:33Z

LGTM, though I would like to see the table view supported for the daily summary. @matthewbirtch Do you have any thoughts on this?

I like the table view for the agenda too. It's quite easy to scan and consume the agenda. A couple questions:

One possible concern for the table view would be mobile though. Displaying this on mobile wouldn't be great. Is it possible to display the other layout on mobile?
Would we add a column for location?
What does the linked subject line go to?
Minor detail: are we able to left-align the Time header cell? It should be left-aligned rather than centered. (like the Subject header cell).

fmartingr · 2023-07-31T13:29:03Z

One possible concern for the table view would be mobile though. Displaying this on mobile wouldn't be great. Is it possible to display the other layout on mobile?

I'm deferring to @mickmister on this one, since I don't think we can but I'm 0/5 on it.

Would we add a column for location?

Yes. For known links that's the plan, adding a "Join meeting" link.

What does the linked subject line go to?

To the event in the Google calendar website.

Minor detail: are we able to left-align the Time header cell? It should be left-aligned rather than centered. (like the Subject header cell).

Yes, that can be done.

mickmister · 2023-07-31T13:38:07Z

One possible concern for the table view would be mobile though. Displaying this on mobile wouldn't be great. Is it possible to display the other layout on mobile?

I'm deferring to @mickmister on this one, since I don't think we can but I'm 0/5 on it.

@fmartingr Are you able to post a screenshot of what this looks like on mobile? I'm also pretty sure that we aren't able to display it differently on mobile

fmartingr · 2023-07-31T13:41:07Z

One possible concern for the table view would be mobile though. Displaying this on mobile wouldn't be great. Is it possible to display the other layout on mobile?

I'm deferring to @mickmister on this one, since I don't think we can but I'm 0/5 on it.

@fmartingr Are you able to post a screenshot of what this looks like on mobile? I'm also pretty sure that we aren't able to display it differently on mobile

Message

When you tap on the lower-right icon

cc: @larkox

larkox · 2023-07-31T15:24:06Z

Displaying different on mobile it is possible, but extremely annoying. Here would be the thing:

On web, it will use a custom post type that will render as a table. This hopefully is simple, but may be become troublesome.
On mobile, since it is not using the custom post type, it will use the default one, that would be that "Slack attachment" view.

The other big issue? When the plugin is disabled (and therefore the custom type does not render on web), the posts will show the "Slack attachment" view, which is weird.

All that being said, I would argue against having different views for them.

…gcal/today-tomorrow

fmartingr · 2023-07-31T16:05:17Z

This is how it looks like on web with the "Join Meeting" cells:

mickmister

Just one question regarding tomorrow date calculation. Otherwise LGTM 👍

mickmister · 2023-07-31T20:35:20Z

server/command/daily_summary.go

@@ -29,11 +29,11 @@ func (c *Command) dailySummary(parameters ...string) (string, bool, error) {
 		}
 		return postStr, false, nil
 	case "tomorrow":
-		_, err := c.MSCalendar.GetDaySummaryForUser(time.Now().Add(time.Hour*24), c.user())
+		postStr, err := c.MSCalendar.GetDaySummaryForUser(time.Now().Add((time.Hour*24)*4), c.user())


Why do we add (time.Hour*24)*4 here? Also do we need to take into account weekends (maybe that's the intention here)?

Oh no no no, I accidentaly commited that. Used to get the output of a specific day for a screenshot.

Though this begs the question, should we have a special case for weekends? Currently, the daily summary job avoids sending the summary on the weekend, so there is already some convention in the plugin to avoid weekends. Maybe the tomorrow command should do something similar?

Didn't check that code, is it configurable? Does it take into consideration countries were weekends are longer/shorter/on different days?

Here is the line that does this

mattermost-plugin-mscalendar/server/mscalendar/daily_summary.go

Line 270 in f226b5e

if now.Weekday() == time.Saturday || now.Weekday() == time.Sunday {

It's currently not configurable, but we can use WorkingHours to figure out the correct days if available for gcal:

mattermost-plugin-mscalendar/server/remote/user.go

Lines 13 to 25 in 65b2e67

type WorkingHours struct {

StartTime string `json:"startTime"`

EndTime string `json:"endTime"`

TimeZone struct {

Name string `json:"name"`

}

DaysOfWeek []string `json:"daysOfWeek"`

}

type MailboxSettings struct {

TimeZone string `json:"timeZone"`

WorkingHours WorkingHours `json:"workingHours"`

}

mickmister · 2023-07-31T20:37:18Z

server/mscalendar/views/calendar.go

+}
+
+func isKnownMeetingURL(location string) bool {
+	return strings.Contains(location, "zoom.us/j/") || strings.Contains(location, "discord.gg") || strings.Contains(location, "meet.google.com")


Neat 👍 Something comes to mind, that a customer may have other call-related domains, including Mattermost Calls. Maybe have this configurable in some way?

Yeah, I want to integrate calls too, but need to send the SITE_URL over to check the URL to do it properly, so it needs a bit more work. Also, Google sends conferenceData for some events instead of location (I'm assuming they have a specific integration), so it wont work every time.

* oauth works * autocomplete * viewcal works * add unimplemented if blocks * fix tests and lint * implement CreateMySubscription, RenewSubscription, and DeleteSubscription gcal methods * WIP gcal subs * setup-attach make target * fix lint and tests * chore: more compatible tar command * add review comments * [GCAL] Create event logic (#269) * remote logic * allow datetimes without timezone * add calendar settings readonly scope to get tz * event conversion * scopes * revert datetime.time * bug: get timezone from datetime instead of event data (#271) * [GCAL] Allow building two different plugins under the same codebase (#268) * plugin profile images * receive provider flag * manifests * retrieve manifest id from file * Build time configuration * revert manifest * using go static configuration for providers * removed unused build flags * revert manifest * Added basic Google Calendar instructions * Update providers/GoogleCalendar.md Co-authored-by: Michael Kochell <[email protected]> * Update providers/GoogleCalendar.md Co-authored-by: Michael Kochell <[email protected]> * Update server/plugin/plugin.go Co-authored-by: Michael Kochell <[email protected]> * remoove log --------- Co-authored-by: Michael Kochell <[email protected]> * [GCAL] Endpoint to autocomplete connected calendar users (#275) * user_store: more information fields on the index * feat: endpoint to autocomplete calendar connected users * revert test event store hashed * Update server/api/autocomplete.go Co-authored-by: Michael Kochell <[email protected]> * Update server/api/autocomplete.go Co-authored-by: Michael Kochell <[email protected]> * dont expose private data in endpoint * lint * Update server/store/user_store.go Co-authored-by: Michael Kochell <[email protected]> --------- Co-authored-by: Michael Kochell <[email protected]> * [GCAL] Refactor Microsoft Calendar references to provider references (#276) * chore: replace provider display name * chore: replace command trigger references * revert previous changes * [GCAL] Enable notifications and reminders when a superuser token is not supported (#272) * nil control * use subscriptions default ttl * return specific error when no superuser token can be used * notification formatting logic to other file * Client.GetEventsBetweenDates * typo: import * shorter command name :) * availability without super user token * delete store subs only if we successfuly do on remote * comment * ignore missing subs * update sync method * allow switching acting user on the fly * daily summary without super user token * formatted imports * calendar -> calendarEvents * processAllDailySummaryByUser -> processAllDailySummaryWithIndividualCredentials * revert silenced error under notifications * msgraph GetEventsBetweenDates * Update server/mscalendar/daily_summary.go Co-authored-by: Michael Kochell <[email protected]> * [GCAL] Create event logic (#269) * remote logic * allow datetimes without timezone * add calendar settings readonly scope to get tz * event conversion * scopes * revert datetime.time * Client.GetEventsBetweenDates * fix: store last post time * refactored availability logic * availability test * refactored daily summary logic * test: availability * daily summary tests (wip) * daily summary test * fix: merge duplications * slack attachment for notifications * lint and test * goimports * Update server/mscalendar/availability.go Co-authored-by: Michael Kochell <[email protected]> * remove logges * nullify client when changing acting user * move withActiveUser filter to fenced code outside of general method * tests: handling more scenarios * Fixed test after bugfix * fixed test assertions * allow engine copy to perform safe state mutations --------- Co-authored-by: Michael Kochell <[email protected]> * [GCAL] Added encrypted key value storage (#270) * Added encrypted kvstore * encrypt only oauth2 kv store * retrieve encryption setting from provider config * explicitly disable encrypted store for mscalendar * remove old comment * [GCAL] today/tomorrow commands with styling (#273) * feat: added today and tomorrow commands with attachments * remove unused function * linted * now -> day * remove unused code * today/tomorrow autocomplete * return tables on today/tomorrow commands * check for nil location * revert tomorrow day times four * fix markdown table render and test * [GCAL] Fix test in main branch from PR merges (#277) * fix: test from merges * add meeting url * [GCAL] Move configuration readyness logic to remotes (#279) * Move configuration logic to remotes * check encryption key as well * Update server/plugin/plugin.go Co-authored-by: Michael Kochell <[email protected]> --------- Co-authored-by: Michael Kochell <[email protected]> * [GCAL] Remove unused code (#278) * remove batch requests from gcal code * More info in readme * [GCAL] Fix event notifications not working due to missing scope permissions plus internal state (#282) * fix: notifications scope and acting user logic * remove log * avoid calling notifications if the engine fails to load * [GCAL] Unsubscriptions (#283) * fix: notifications scope and acting user logic * fix: gcal unsubscribe requiring more parameters * update gcal manifest (#285) * [GCAL] Better logging information (#287) * fix: better log information * log missing error * use correct manifest file on manifest calls (#290) * [GCAL] Embed tzdata and correctly parse location from event datetime (#288) * fix: embed tzdata to prevent errors on systems without it installed * move to main * avoid overwritting location if empty * use tags instead of import * [GCAL] Event notifications behind a feature flag (#292) * put event notifications behind a feature flag * admin only un/subscribe commands * properly fence notification processor * ignore notifications if there's no processor (#293) * [GCAL] Remove join event column (broken from merges) (#294) * remove join column from merges * revert manifest * [GCAL] Channels reminder underlying logic (#274) * nil control * use subscriptions default ttl * return specific error when no superuser token can be used * notification formatting logic to other file * Client.GetEventsBetweenDates * typo: import * shorter command name :) * availability without super user token * delete store subs only if we successfuly do on remote * comment * ignore missing subs * update sync method * allow switching acting user on the fly * daily summary without super user token * formatted imports * calendar -> calendarEvents * processAllDailySummaryByUser -> processAllDailySummaryWithIndividualCredentials * revert silenced error under notifications * msgraph GetEventsBetweenDates * Update server/mscalendar/daily_summary.go Co-authored-by: Michael Kochell <[email protected]> * [GCAL] Create event logic (#269) * remote logic * allow datetimes without timezone * add calendar settings readonly scope to get tz * event conversion * scopes * revert datetime.time * Client.GetEventsBetweenDates * fix: store last post time * refactored availability logic * availability test * refactored daily summary logic * test: availability * daily summary tests (wip) * daily summary test * fix: merge duplications * slack attachment for notifications * lint and test * goimports * Allow poster to create posts * Allow store event metadata * styling * store recurring event id * deliver channel notifications * test: fixed for base case * test: channel reminders * test: recurring events * move from slice to map * Added store methods to interact with event metadata * lint * lint imports * restore logic lost in merge * duplicated test * Update server/mscalendar/availability_test.go Co-authored-by: Michael Kochell <[email protected]> * remove recurrent event id field --------- Co-authored-by: Michael Kochell <[email protected]> * Updated google calendar readme * [GCAL] Summary command fixes (#286) * command trigger shown * added autocomplete to summary command * remove join meeting column * fix event subjects with table separator * fixed merge import * replace more characters in subject * [GCAL] Add a modal to create events (#281) * add webapp folder * WIP * opening create event modal from slash command works * add time selectors and initial impl of attendee selector * delete .npminstall * ignore .npminstall * [GCAL/MSCAL] Add endpoint to create events from the frontend (#291) * add remoteid to event attendee * api endpoint * conversion fixes * api logic * frontend logic to test * check if user belongs to channel * updated interface * use api/v1 prefix * implement getchannelmember * all day events * pluginAPI.CanLinkEventToChannel * autocomplete users * create event fetch call * channel autocomplete * improved error messages displayed to users * better error handling * channel selector store channel id * properly set email addresses for attendees * event location as string * response messages * little refactor * attendee selector can invite arbitrary emails * uppercase error dynamically * lowercase error * remove punctuation * linted ts files * goimports * fixed import * link events on creation * Add channel action to create events * add channel_id to payload * time selector every 15 minutes * time selector start/end with limits * capitalized error messages * don't allow 0 minute events * display timezone in channel reminders * utc time parsing * remove nullfunc * properly initialize variables * address some comments * npm run fix * Update webapp/src/components/time_selector.tsx Co-authored-by: Michael Kochell <[email protected]> * Update webapp/src/components/time_selector.tsx Co-authored-by: Michael Kochell <[email protected]> * refactor options with useMemo * capitalization in function for clarity * npm run fix * get plugin id from manifest * remove no-ops * refactor createEvent * fix channel autocomplete url * fix lint * fix user string typo * make it so `make apply` assumes gcal for now * more careful error handling * reorganize frontend error handling * default to CALENDAR_PROVIDER=gcal * use Client4.autocompleteChannels instead of custom plugin endpoint * fix manifest test --------- Co-authored-by: Michael Kochell <[email protected]> * gofmt --------- Co-authored-by: Felipe Martin <[email protected]> Co-authored-by: Felipe Martin <[email protected]> * [GCAL/MSCAL] Store linked events per user to remove links on disconnection (#296) * add webapp folder * WIP * opening create event modal from slash command works * add time selectors and initial impl of attendee selector * delete .npminstall * ignore .npminstall * add remoteid to event attendee * api endpoint * conversion fixes * api logic * frontend logic to test * check if user belongs to channel * updated interface * use api/v1 prefix * implement getchannelmember * all day events * pluginAPI.CanLinkEventToChannel * autocomplete users * create event fetch call * channel autocomplete * improved error messages displayed to users * better error handling * channel selector store channel id * properly set email addresses for attendees * event location as string * response messages * little refactor * attendee selector can invite arbitrary emails * uppercase error dynamically * lowercase error * remove punctuation * linted ts files * goimports * fixed import * link events on creation * Add channel action to create events * add channel_id to payload * time selector every 15 minutes * time selector start/end with limits * capitalized error messages * don't allow 0 minute events * display timezone in channel reminders * utc time parsing * remove nullfunc * properly initialize variables * address some comments * npm run fix * store linked events for user to remove links on disconnection * typo * remove unused items after merge --------- Co-authored-by: Michael Kochell <[email protected]> * [GCAL/MSCAL] Remind only accepted events (#295) * remind only accepted events * fixed tests * excludeDeclinedEvents * normalize msgraph event response * Remove GoogleDomainVerifyKey setting (#299) * fix: encrypt user store (#297) * feat: send notifications when an event is created (#300) * typo: user already connected message (#301) * typo: user already connected message * test: fix change * typo: user already connected message (#301) * typo: user already connected message * test: fix change * [GCAL/MSCAL] Exclude rejected events from agenda commands (#302) * exclude rejected events from agenda commands * test: check that declied event are excluded * fix possible nil pointer * [GCAL/MSCAL] Create event modal only for connected accounts (#303) * only connected users chan use slash command * prevent channel menu action from allowing too * npm run fix * lint errors * retrieve provider configuration to use in messages * websocket events * add message to mobile users * npm run fix * Update webapp/src/plugin_hooks.ts Co-authored-by: Michael Kochell <[email protected]> * register modal in setup * events create * trigger from provide config * using dispatch * missing semicolon * Update webapp/src/plugin_hooks.ts Co-authored-by: Michael Kochell <[email protected]> * singular --------- Co-authored-by: Michael Kochell <[email protected]> * updated settings to use style and removed current value line (#305) * show link to connect if not connected (#306) * [GCAL/MSCAL] Reduce welcome steps (#308) * reduce welcome steps and edit defaults * Update server/mscalendar/welcome_flow.go Co-authored-by: Michael Kochell <[email protected]> --------- Co-authored-by: Michael Kochell <[email protected]> * [GCAL/MSCAL] Control start/date times if the selected date is today (#307) * improvements to create event datetimes * reset starttime endtime on date change * repopulate times if date changed * npm run fix * database replication workaround (#312) * [GCAL/MSCAL] Catch errors when using `findmeetings` commands without enough parameters (#313) * fix: handle error in find meetings parameters command * changed loop variable usage * Replace Equals with ElementsMatch * makefile dist build for production (#314) * [GCAL/MSCAL] Create event UX improvements (#309) * Optional fields * time picker defaults * Add custom icon to Create Event menu item * add custom icon to date selector * npm run fix * header menu icon multiline * use scss * using proper typeRoots * scoped css style * [GCAL] Store conference data (#298) * extract conference data into new attribute * removed log * removed unused fuunction * tests * Update server/remote/gcal/get_default_calendar_view_test.go Co-authored-by: Michael Kochell <[email protected]> * more realistic datetime values --------- Co-authored-by: Michael Kochell <[email protected]> * Common code refactor, back to mscalendar plugin (#334) * refactor: mscalendar -> engine * remove gcal assets * refactored common code outside server package * check-style * go mod tidy * REPO_URL -> REPOSITORY_URL * delete unknown file * updated mocks * apped user to handle after all actions (#335) * refactor msgraph to mscalendar * goimports * removed apply command from merge * remove "REVIEW:" comments --------- Co-authored-by: Felipe Martin <[email protected]> Co-authored-by: Felipe Martin <[email protected]>

* oauth works * autocomplete * viewcal works * add unimplemented if blocks * fix tests and lint * implement CreateMySubscription, RenewSubscription, and DeleteSubscription gcal methods * WIP gcal subs * setup-attach make target * fix lint and tests * chore: more compatible tar command * add review comments * [GCAL] Create event logic (#269) * remote logic * allow datetimes without timezone * add calendar settings readonly scope to get tz * event conversion * scopes * revert datetime.time * bug: get timezone from datetime instead of event data (#271) * [GCAL] Allow building two different plugins under the same codebase (#268) * plugin profile images * receive provider flag * manifests * retrieve manifest id from file * Build time configuration * revert manifest * using go static configuration for providers * removed unused build flags * revert manifest * Added basic Google Calendar instructions * Update providers/GoogleCalendar.md Co-authored-by: Michael Kochell <[email protected]> * Update providers/GoogleCalendar.md Co-authored-by: Michael Kochell <[email protected]> * Update server/plugin/plugin.go Co-authored-by: Michael Kochell <[email protected]> * remoove log --------- Co-authored-by: Michael Kochell <[email protected]> * [GCAL] Endpoint to autocomplete connected calendar users (#275) * user_store: more information fields on the index * feat: endpoint to autocomplete calendar connected users * revert test event store hashed * Update server/api/autocomplete.go Co-authored-by: Michael Kochell <[email protected]> * Update server/api/autocomplete.go Co-authored-by: Michael Kochell <[email protected]> * dont expose private data in endpoint * lint * Update server/store/user_store.go Co-authored-by: Michael Kochell <[email protected]> --------- Co-authored-by: Michael Kochell <[email protected]> * [GCAL] Refactor Microsoft Calendar references to provider references (#276) * chore: replace provider display name * chore: replace command trigger references * revert previous changes * [GCAL] Enable notifications and reminders when a superuser token is not supported (#272) * nil control * use subscriptions default ttl * return specific error when no superuser token can be used * notification formatting logic to other file * Client.GetEventsBetweenDates * typo: import * shorter command name :) * availability without super user token * delete store subs only if we successfuly do on remote * comment * ignore missing subs * update sync method * allow switching acting user on the fly * daily summary without super user token * formatted imports * calendar -> calendarEvents * processAllDailySummaryByUser -> processAllDailySummaryWithIndividualCredentials * revert silenced error under notifications * msgraph GetEventsBetweenDates * Update server/mscalendar/daily_summary.go Co-authored-by: Michael Kochell <[email protected]> * [GCAL] Create event logic (#269) * remote logic * allow datetimes without timezone * add calendar settings readonly scope to get tz * event conversion * scopes * revert datetime.time * Client.GetEventsBetweenDates * fix: store last post time * refactored availability logic * availability test * refactored daily summary logic * test: availability * daily summary tests (wip) * daily summary test * fix: merge duplications * slack attachment for notifications * lint and test * goimports * Update server/mscalendar/availability.go Co-authored-by: Michael Kochell <[email protected]> * remove logges * nullify client when changing acting user * move withActiveUser filter to fenced code outside of general method * tests: handling more scenarios * Fixed test after bugfix * fixed test assertions * allow engine copy to perform safe state mutations --------- Co-authored-by: Michael Kochell <[email protected]> * [GCAL] Added encrypted key value storage (#270) * Added encrypted kvstore * encrypt only oauth2 kv store * retrieve encryption setting from provider config * explicitly disable encrypted store for mscalendar * remove old comment * [GCAL] today/tomorrow commands with styling (#273) * feat: added today and tomorrow commands with attachments * remove unused function * linted * now -> day * remove unused code * today/tomorrow autocomplete * return tables on today/tomorrow commands * check for nil location * revert tomorrow day times four * fix markdown table render and test * [GCAL] Fix test in main branch from PR merges (#277) * fix: test from merges * add meeting url * [GCAL] Move configuration readyness logic to remotes (#279) * Move configuration logic to remotes * check encryption key as well * Update server/plugin/plugin.go Co-authored-by: Michael Kochell <[email protected]> --------- Co-authored-by: Michael Kochell <[email protected]> * [GCAL] Remove unused code (#278) * remove batch requests from gcal code * More info in readme * [GCAL] Fix event notifications not working due to missing scope permissions plus internal state (#282) * fix: notifications scope and acting user logic * remove log * avoid calling notifications if the engine fails to load * [GCAL] Unsubscriptions (#283) * fix: notifications scope and acting user logic * fix: gcal unsubscribe requiring more parameters * update gcal manifest (#285) * [GCAL] Better logging information (#287) * fix: better log information * log missing error * use correct manifest file on manifest calls (#290) * [GCAL] Embed tzdata and correctly parse location from event datetime (#288) * fix: embed tzdata to prevent errors on systems without it installed * move to main * avoid overwritting location if empty * use tags instead of import * [GCAL] Event notifications behind a feature flag (#292) * put event notifications behind a feature flag * admin only un/subscribe commands * properly fence notification processor * ignore notifications if there's no processor (#293) * [GCAL] Remove join event column (broken from merges) (#294) * remove join column from merges * revert manifest * [GCAL] Channels reminder underlying logic (#274) * nil control * use subscriptions default ttl * return specific error when no superuser token can be used * notification formatting logic to other file * Client.GetEventsBetweenDates * typo: import * shorter command name :) * availability without super user token * delete store subs only if we successfuly do on remote * comment * ignore missing subs * update sync method * allow switching acting user on the fly * daily summary without super user token * formatted imports * calendar -> calendarEvents * processAllDailySummaryByUser -> processAllDailySummaryWithIndividualCredentials * revert silenced error under notifications * msgraph GetEventsBetweenDates * Update server/mscalendar/daily_summary.go Co-authored-by: Michael Kochell <[email protected]> * [GCAL] Create event logic (#269) * remote logic * allow datetimes without timezone * add calendar settings readonly scope to get tz * event conversion * scopes * revert datetime.time * Client.GetEventsBetweenDates * fix: store last post time * refactored availability logic * availability test * refactored daily summary logic * test: availability * daily summary tests (wip) * daily summary test * fix: merge duplications * slack attachment for notifications * lint and test * goimports * Allow poster to create posts * Allow store event metadata * styling * store recurring event id * deliver channel notifications * test: fixed for base case * test: channel reminders * test: recurring events * move from slice to map * Added store methods to interact with event metadata * lint * lint imports * restore logic lost in merge * duplicated test * Update server/mscalendar/availability_test.go Co-authored-by: Michael Kochell <[email protected]> * remove recurrent event id field --------- Co-authored-by: Michael Kochell <[email protected]> * Updated google calendar readme * [GCAL] Summary command fixes (#286) * command trigger shown * added autocomplete to summary command * remove join meeting column * fix event subjects with table separator * fixed merge import * replace more characters in subject * [GCAL] Add a modal to create events (#281) * add webapp folder * WIP * opening create event modal from slash command works * add time selectors and initial impl of attendee selector * delete .npminstall * ignore .npminstall * [GCAL/MSCAL] Add endpoint to create events from the frontend (#291) * add remoteid to event attendee * api endpoint * conversion fixes * api logic * frontend logic to test * check if user belongs to channel * updated interface * use api/v1 prefix * implement getchannelmember * all day events * pluginAPI.CanLinkEventToChannel * autocomplete users * create event fetch call * channel autocomplete * improved error messages displayed to users * better error handling * channel selector store channel id * properly set email addresses for attendees * event location as string * response messages * little refactor * attendee selector can invite arbitrary emails * uppercase error dynamically * lowercase error * remove punctuation * linted ts files * goimports * fixed import * link events on creation * Add channel action to create events * add channel_id to payload * time selector every 15 minutes * time selector start/end with limits * capitalized error messages * don't allow 0 minute events * display timezone in channel reminders * utc time parsing * remove nullfunc * properly initialize variables * address some comments * npm run fix * Update webapp/src/components/time_selector.tsx Co-authored-by: Michael Kochell <[email protected]> * Update webapp/src/components/time_selector.tsx Co-authored-by: Michael Kochell <[email protected]> * refactor options with useMemo * capitalization in function for clarity * npm run fix * get plugin id from manifest * remove no-ops * refactor createEvent * fix channel autocomplete url * fix lint * fix user string typo * make it so `make apply` assumes gcal for now * more careful error handling * reorganize frontend error handling * default to CALENDAR_PROVIDER=gcal * use Client4.autocompleteChannels instead of custom plugin endpoint * fix manifest test --------- Co-authored-by: Michael Kochell <[email protected]> * gofmt --------- Co-authored-by: Felipe Martin <[email protected]> Co-authored-by: Felipe Martin <[email protected]> * [GCAL/MSCAL] Store linked events per user to remove links on disconnection (#296) * add webapp folder * WIP * opening create event modal from slash command works * add time selectors and initial impl of attendee selector * delete .npminstall * ignore .npminstall * add remoteid to event attendee * api endpoint * conversion fixes * api logic * frontend logic to test * check if user belongs to channel * updated interface * use api/v1 prefix * implement getchannelmember * all day events * pluginAPI.CanLinkEventToChannel * autocomplete users * create event fetch call * channel autocomplete * improved error messages displayed to users * better error handling * channel selector store channel id * properly set email addresses for attendees * event location as string * response messages * little refactor * attendee selector can invite arbitrary emails * uppercase error dynamically * lowercase error * remove punctuation * linted ts files * goimports * fixed import * link events on creation * Add channel action to create events * add channel_id to payload * time selector every 15 minutes * time selector start/end with limits * capitalized error messages * don't allow 0 minute events * display timezone in channel reminders * utc time parsing * remove nullfunc * properly initialize variables * address some comments * npm run fix * store linked events for user to remove links on disconnection * typo * remove unused items after merge --------- Co-authored-by: Michael Kochell <[email protected]> * [GCAL/MSCAL] Remind only accepted events (#295) * remind only accepted events * fixed tests * excludeDeclinedEvents * normalize msgraph event response * Remove GoogleDomainVerifyKey setting (#299) * fix: encrypt user store (#297) * feat: send notifications when an event is created (#300) * typo: user already connected message (#301) * typo: user already connected message * test: fix change * typo: user already connected message (#301) * typo: user already connected message * test: fix change * [GCAL/MSCAL] Exclude rejected events from agenda commands (#302) * exclude rejected events from agenda commands * test: check that declied event are excluded * fix possible nil pointer * [GCAL/MSCAL] Create event modal only for connected accounts (#303) * only connected users chan use slash command * prevent channel menu action from allowing too * npm run fix * lint errors * retrieve provider configuration to use in messages * websocket events * add message to mobile users * npm run fix * Update webapp/src/plugin_hooks.ts Co-authored-by: Michael Kochell <[email protected]> * register modal in setup * events create * trigger from provide config * using dispatch * missing semicolon * Update webapp/src/plugin_hooks.ts Co-authored-by: Michael Kochell <[email protected]> * singular --------- Co-authored-by: Michael Kochell <[email protected]> * updated settings to use style and removed current value line (#305) * show link to connect if not connected (#306) * [GCAL/MSCAL] Reduce welcome steps (#308) * reduce welcome steps and edit defaults * Update server/mscalendar/welcome_flow.go Co-authored-by: Michael Kochell <[email protected]> --------- Co-authored-by: Michael Kochell <[email protected]> * [GCAL/MSCAL] Control start/date times if the selected date is today (#307) * improvements to create event datetimes * reset starttime endtime on date change * repopulate times if date changed * npm run fix * database replication workaround (#312) * [GCAL/MSCAL] Catch errors when using `findmeetings` commands without enough parameters (#313) * fix: handle error in find meetings parameters command * changed loop variable usage * Replace Equals with ElementsMatch * makefile dist build for production (#314) * [GCAL/MSCAL] Create event UX improvements (#309) * Optional fields * time picker defaults * Add custom icon to Create Event menu item * add custom icon to date selector * npm run fix * header menu icon multiline * use scss * using proper typeRoots * scoped css style * [GCAL] Store conference data (#298) * extract conference data into new attribute * removed log * removed unused fuunction * tests * Update server/remote/gcal/get_default_calendar_view_test.go Co-authored-by: Michael Kochell <[email protected]> * more realistic datetime values --------- Co-authored-by: Michael Kochell <[email protected]> * Common code refactor, back to mscalendar plugin (#334) * refactor: mscalendar -> engine * remove gcal assets * refactored common code outside server package * check-style * go mod tidy * REPO_URL -> REPOSITORY_URL * delete unknown file * updated mocks * apped user to handle after all actions (#335) * refactor msgraph to mscalendar * refactor: removed unused commands * Update calendar/command/command.go Co-authored-by: Michael Kochell <[email protected]> * go mod tidy * removed added code from merge --------- Co-authored-by: Michael Kochell <[email protected]> Co-authored-by: Raghav Aggarwal <[email protected]> Co-authored-by: Doug Lauder <[email protected]>

feat: added today and tomorrow commands with attachments

3bc5846

fmartingr requested a review from mickmister as a code owner July 27, 2023 08:17

fmartingr self-assigned this Jul 27, 2023

fmartingr added 2 commits July 27, 2023 10:28

remove unused function

92a91c1

linted

6273977

mickmister approved these changes Jul 28, 2023

View reviewed changes

server/mscalendar/daily_summary.go Outdated Show resolved Hide resolved

server/mscalendar/views/calendar.go Outdated Show resolved Hide resolved

fmartingr added 2 commits July 29, 2023 07:43

now -> day

002786c

remove unused code

ed9d16b

mickmister approved these changes Jul 31, 2023

View reviewed changes

Merge remote-tracking branch 'origin/migrate-to-gcal' into fmartingr/…

70c7917

…gcal/today-tomorrow

fmartingr added 3 commits July 31, 2023 18:05

today/tomorrow autocomplete

18c6e37

return tables on today/tomorrow commands

c738f90

check for nil location

a35e3de

mickmister reviewed Jul 31, 2023

View reviewed changes

fmartingr added 2 commits August 1, 2023 08:43

revert tomorrow day times four

64e22f5

fix markdown table render and test

cfe4ba3

fmartingr merged commit 421c8d5 into migrate-to-gcal Aug 1, 2023
4 checks passed

fmartingr deleted the fmartingr/gcal/today-tomorrow branch August 1, 2023 07:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GCAL] today/tomorrow commands with styling #273

[GCAL] today/tomorrow commands with styling #273

fmartingr commented Jul 27, 2023

codecov-commenter commented Jul 27, 2023 •

edited

Loading

mickmister commented Jul 28, 2023

mickmister left a comment

fmartingr commented Jul 29, 2023 •

edited

Loading

mickmister commented Jul 31, 2023

mickmister left a comment

jasonblais commented Jul 31, 2023

matthewbirtch commented Jul 31, 2023 •

edited

Loading

fmartingr commented Jul 31, 2023

mickmister commented Jul 31, 2023

fmartingr commented Jul 31, 2023

larkox commented Jul 31, 2023

fmartingr commented Jul 31, 2023

mickmister left a comment

mickmister Jul 31, 2023

fmartingr Aug 1, 2023

mickmister Aug 1, 2023

fmartingr Aug 1, 2023

mickmister Aug 1, 2023

mickmister Jul 31, 2023

fmartingr Aug 1, 2023

	type WorkingHours struct {
	StartTime string `json:"startTime"`
	EndTime string `json:"endTime"`
	TimeZone struct {
	Name string `json:"name"`
	}
	DaysOfWeek []string `json:"daysOfWeek"`
	}

	type MailboxSettings struct {
	TimeZone string `json:"timeZone"`
	WorkingHours WorkingHours `json:"workingHours"`
	}

[GCAL] today/tomorrow commands with styling #273

[GCAL] today/tomorrow commands with styling #273

Conversation

fmartingr commented Jul 27, 2023

Summary

Ticket Link

Notes

Screenshots

codecov-commenter commented Jul 27, 2023 • edited Loading

Codecov Report

mickmister commented Jul 28, 2023

mickmister left a comment

Choose a reason for hiding this comment

fmartingr commented Jul 29, 2023 • edited Loading

Table view

Attachment view

mickmister commented Jul 31, 2023

mickmister left a comment

Choose a reason for hiding this comment

jasonblais commented Jul 31, 2023

matthewbirtch commented Jul 31, 2023 • edited Loading

fmartingr commented Jul 31, 2023

mickmister commented Jul 31, 2023

fmartingr commented Jul 31, 2023

Message

When you tap on the lower-right icon

larkox commented Jul 31, 2023

fmartingr commented Jul 31, 2023

mickmister left a comment

Choose a reason for hiding this comment

mickmister Jul 31, 2023

Choose a reason for hiding this comment

fmartingr Aug 1, 2023

Choose a reason for hiding this comment

mickmister Aug 1, 2023

Choose a reason for hiding this comment

fmartingr Aug 1, 2023

Choose a reason for hiding this comment

mickmister Aug 1, 2023

Choose a reason for hiding this comment

mickmister Jul 31, 2023

Choose a reason for hiding this comment

fmartingr Aug 1, 2023

Choose a reason for hiding this comment

codecov-commenter commented Jul 27, 2023 •

edited

Loading

fmartingr commented Jul 29, 2023 •

edited

Loading

matthewbirtch commented Jul 31, 2023 •

edited

Loading