Added test cases for critical PRs of Jira release 4.0.0 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [MI-3516]: Added the extra test cases in this PR * [MI-3516]: Added an extra test cases in this PR * [MI-3516]: Added an extra test cases in this PR * [MI-3516]:Fixed review comments * [MI-3516]:Fixed a review comments * [MI-3516] Review fix Co-authored-by: kshitij katiyar <[email protected]> --------- Co-authored-by: kshitij katiyar <[email protected]>
AayushChaudhary0001
changed the title
|
/update-branch |
saturninoabril
requested changes
Sep 26, 2023
There was a problem hiding this comment.
Thanks @AayushChaudhary0001! Looks good to me except few comments. Also, please update your branch to latest. You may validate your change locally by deno task validate and fix error before pushing. Let me know if you need help.
data/test-cases/plugins/jira/jira-server/install-and-uninstall/Disconnect_POST_API.md
Outdated
Show resolved
Hide resolved
data/test-cases/plugins/jira/jira-server/install-and-uninstall/Disconnect_POST_API.md
Outdated
Show resolved
Hide resolved
data/test-cases/plugins/jira/jira-server/install-and-uninstall/Disconnect_POST_API.md
Outdated
Show resolved
Hide resolved
data/test-cases/plugins/jira/jira-server/install-and-uninstall/Disconnect_POST_API_2.md
Outdated
Show resolved
Hide resolved
data/test-cases/plugins/jira/jira-server/install-and-uninstall/OAuth_Setup.md
Outdated
Show resolved
Hide resolved
saturninoabril
requested changes
Oct 4, 2023
data/test-cases/plugins/jira/jira-server/install-and-uninstall/Disconnect_POST_API.md
Outdated
Show resolved
Hide resolved
data/test-cases/plugins/jira/jira-server/install-and-uninstall/Disconnect_POST_API.md
Outdated
Show resolved
Hide resolved
data/test-cases/plugins/jira/jira-server/install-and-uninstall/OAuth_Setup.md
Outdated
Show resolved
Hide resolved
data/test-cases/plugins/jira/jira-server/jira-subscriptions/Comment_Notification.md
Outdated
Show resolved
Hide resolved
data/test-cases/plugins/jira/jira-server/jira-subscriptions/DM_Comment_notification.md
Outdated
Show resolved
Hide resolved
data/test-cases/plugins/jira/jira-server/jira-subscriptions/DM_Comment_notification_2.md
Outdated
Show resolved
Hide resolved
saturninoabril
approved these changes
Oct 8, 2023
| **Step 1** | ||
|
|
||
| 1. Go to the connected Jira instance. | ||
| 2. Open the desired ticket on Jira board. |
There was a problem hiding this comment.
On this point, to prevent a false positive I would add a step that says "Ensure the test user desired user is not the assignee on the ticket"
Assignee get DMs for any comment so we should ensure the user is explicitly not seeing this DM.
| **Step 1** | ||
|
|
||
| 1. Go to the connected Jira instance. | ||
| 2. Open the desired ticket on Jira board. |
|
This is great @AayushChaudhary0001! |
|
@DHaussermann Just following up on next step here. Thanks! |
|
@AayushChaudhary0001 just to circle back to this. There was 1 check suggested on 2 of the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This consist of the test cases of critical PR's of Jira release 4.0.0
Test coverage for:-
mattermost/mattermost-plugin-jira#951
mattermost/mattermost-plugin-jira#949
mattermost/mattermost-plugin-jira#953
mattermost/mattermost-plugin-jira#946
mattermost/mattermost-plugin-jira#961
Is the feature in stable branch or under review?
Feature in stable branch (master, main)?