-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8.1 Notice #350
v8.1 Notice #350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Amy!
@amyblais do you know if there is a way to apply these changes to test servers, specifying the different server versions? I'm not sure how to test this kind of change before it's merged. This repo can't spin up its own test servers I don't believe, even of just one version. 🤔 |
@lindalumitchell Here are instructions: https://github.com/mattermost/notices#how-to-test-notices-via-cloud-plugin. |
Thanks @amyblais! I'm afraid I'm still unclear about this first step from those instructions: "Prepare notices.json and merge it into the master branch." It doesn't appear that that has happened, so that I would be able to use |
@lindalumitchell The |
Since Yasser already has some experience with testing notices, I'm ok with waiting until next week and adding him as a reviewer here. |
Ah I see, thank you Amy. I'm giving it a try, and if I don't get it we can wait until next week when Yasser is back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified using #351 and #352 (per https://github.com/mattermost/notices#how-to-test-notices-via-cloud-plugin) and spinning up v8.0 and v8.1 servers using /cloud. Verified that the notice appears on v8.0 as expected and the links work, and that the notice does not appear on v8.1 as expected. 👍
Summary
Screenshots of the modals or screens in all target clients (required)
Test environment (required)
Test steps and expectation (required)