-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gif picker deprecation notice #354
Conversation
notices.json
Outdated
"conditions": { | ||
"audience": "sysadmin", | ||
"instanceType": "onprem", | ||
"serverVersion": ["<7.8.9", "8.0.0-8.0.1", "8.1.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johndavidlugtu @amyblais can you double check these server versions that the notice will be displayed:
- Servers below v7.8.9
- v8.0.0 and v8.0.1
- v8.1.0
All other versions after v8.1.0 shouldn't get the notice. Did I miss any?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also v7.9 and v7.10 versions should get the notice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch. Missed those. I add the "7.9-7.10"
which I'm hoping the notices is picked up by any dot releases on those versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @marianunez ,
just curious if this change should be going into release
branch ?
once merged to master, I can test this on different server versions.
Yes, we want to test this so I'll merge to |
Sure @marianunez , I'll test it on the mentioned versions. |
Summary
Gfycat deprecation notice as defined in here
Jira ticket
https://mattermost.atlassian.net/browse/MM-54280
Screenshots of the modals or screens in all target clients (required)
Test steps and expectation (required)