Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gif picker deprecation notice #354

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Gif picker deprecation notice #354

merged 3 commits into from
Aug 29, 2023

Conversation

marianunez
Copy link
Member

@marianunez marianunez commented Aug 28, 2023

Summary

Gfycat deprecation notice as defined in here

Jira ticket

https://mattermost.atlassian.net/browse/MM-54280

Screenshots of the modals or screens in all target clients (required)

Test steps and expectation (required)

  • Notice should appear for on-prem servers only:
    • Servers below v7.8.9
    • v7.9-v7.10
    • v8.0.0 and v8.0.1
    • v8.1.0
  • Notice should not appear in Cloud and should not appear in versions v.7.8.9, 8.0.2, 8.1.1 or 9.0 and above
  • Notice should only appear for admins.
  • Learn more button should go to the forum post.

notices.json Outdated
"conditions": {
"audience": "sysadmin",
"instanceType": "onprem",
"serverVersion": ["<7.8.9", "8.0.0-8.0.1", "8.1.0"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johndavidlugtu @amyblais can you double check these server versions that the notice will be displayed:

  • Servers below v7.8.9
  • v8.0.0 and v8.0.1
  • v8.1.0

All other versions after v8.1.0 shouldn't get the notice. Did I miss any?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also v7.9 and v7.10 versions should get the notice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch. Missed those. I add the "7.9-7.10" which I'm hoping the notices is picked up by any dot releases on those versions

@marianunez marianunez added 1: PM Review Requires review by a product manager 2: QA Review Requires review by a QA tester labels Aug 28, 2023
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marianunez ,
just curious if this change should be going into release branch ?

once merged to master, I can test this on different server versions.

@marianunez
Copy link
Member Author

Hi @marianunez ,
just curious if this change should be going into release branch ?

once merged to master, I can test this on different server versions.

Yes, we want to test this so I'll merge to master now so you can test @yasserfaraazkhan

@marianunez marianunez merged commit 13749bf into master Aug 29, 2023
1 check passed
@marianunez marianunez deleted the gfycat-deprecation branch August 29, 2023 10:24
@yasserfaraazkhan
Copy link
Contributor

Sure @marianunez , I'll test it on the mentioned versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: PM Review Requires review by a product manager 2: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants