-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix platform tag version regression for macOS 11 and later #219
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
==========================================
+ Coverage 96.94% 96.99% +0.05%
==========================================
Files 16 16
Lines 1308 1333 +25
==========================================
+ Hits 1268 1293 +25
Misses 40 40 ☔ View full report in Codecov by Sentry. |
ce5cc99
to
1561977
Compare
Multiple sections of code had mislabeled Only I've decided to deprecate |
Add tests for target release versions Tests using env need to copy environ to ensure that subprocess works correctly
`--require-target-macos-version` could cause confusion in its current state. It was probably a mistake to add it.
Add macOS 12.1 test data
Simplify code involving architectures by working with their unpacked forms Fixed code and tests which mislabeled `intel` as `universal`
This flag is redundant and does not mesh well with the MACOSX_DEPLOYMENT_TARGET environment variable.
Add relevant architecture to the deceptive tag warning.
382b090
to
19b5121
Compare
Zero out minor version of platform tags for macOS 11 and later which fixes the invalid tags for those releases. Closes #214
Delocate has a bias for testing older versions of macOS. I've added a test to ensure this works as intended.
Also discussed about in #214. This updates the behavior of
MACOSX_DEPLOYMENT_TARGET
and--require-target-macos-version
. These will now raise the resulting platform tag versions if they are lower than the requested version. I'm certain this is desirable forMACOSX_DEPLOYMENT_TARGET
but I'm not sure if it should be the same for--require-target-macos-version
.