Require Python 3.9, apply pyupgrade linter #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 96.99% 97.05% +0.05%
==========================================
Files 16 16
Lines 1333 1326 -7
==========================================
- Hits 1293 1287 -6
+ Misses 40 39 -1 ☔ View full report in Codecov by Sentry. |
Remove `raise ValueError` on missing patch file. This was always extraneous since the open call would've raised `FileNotFoundError` on its own. Normally I wouldn't add an undocumented raise to the changelog, but I'm being safe. Convert to pathlib and use str types for Popen.
HexDecimal
force-pushed
the
python-3.9
branch
from
65cb378 to
85e4719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 is nearly end-of-life and I'd like to access to the
is_relative_tomethods of the pathlib library of Python 3.9.Removed
.mypy.iniby moving its settings topyproject.toml.The PR will apply and enforce the Ruff rules
UP(pyupgrade) andFA(flake8-future-annotations). This will automate various maintenance tasks and replace a lot of outdated syntax.