Weel name fix parse header #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czaki
force-pushed
the
weel_name_fix_parse_header
branch
from
8a3f421
to
1432c28
Compare
add test_data to manifest add test data to package
Czaki
force-pushed
the
weel_name_fix_parse_header
branch
from
05bbea0
to
aca51fa
Compare
Czaki
force-pushed
the
weel_name_fix_parse_header
branch
from
aca51fa
to
b1f694a
Compare
radarhere
reviewed
Jan 10, 2021
Co-authored-by: Andrew Murray <[email protected]>
radarhere
reviewed
Mar 7, 2023
|
|
||
| def read_mach_header(lib_file, seek=None): | ||
| """ | ||
| This funcition parse mach-O header and extract |
There was a problem hiding this comment.
Suggested change
| This funcition parse mach-O header and extract | |
| This function parses mach-O header and extracts |
radarhere
reviewed
Mar 7, 2023
| - For fat files this implementation looks for maximum number version. | ||
| It not check if it is 32 or 64 and do not compare it with currently builded package. | ||
| So it is possible to false report higher version that needed. | ||
| - All structures signatures are taken form macosx header files. |
There was a problem hiding this comment.
Suggested change
| - All structures signatures are taken form macosx header files. | |
| - All structure signatures are taken from macosx header files. |
|
I'm sorry. I lost access to macOS machine during work on this PR a few years ago (currently only have Linux and windows) I may try to do this, even using macholib, but without any option to test other than GHA. Or maybe someone could provide remote access to macOS machine. |
|
Hi @Czaki - you're welcome to log into my machine at home if you want. Can you send your ssh public key to me via email? - matthew.brett at gmail |
|
I have sent mail. |
|
Resolved by #198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing wheel name with parsing header from python code (based on pypa/wheel#314) and calculate proper platform tag.
delocate_wheel