Skip to content

Commit

Permalink
final maintenance before starting ai_pip
Browse files Browse the repository at this point in the history
  • Loading branch information
matthewdeanmartin committed Nov 4, 2023
1 parent 7c03f12 commit be94be0
Show file tree
Hide file tree
Showing 12 changed files with 15 additions and 31 deletions.
3 changes: 1 addition & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
// "forwardPorts": [],

// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": "pipenv sync --dev",
"postCreateCommand": "poetry install --with dev",

// Comment out to connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
"remoteUser": "vscode",
Expand All @@ -56,7 +56,6 @@
"ghcr.io/devcontainers-contrib/features/black:2": {},
"ghcr.io/devcontainers-contrib/features/coverage-py:2": {},
"ghcr.io/devcontainers-contrib/features/isort:2": {},
"ghcr.io/devcontainers-contrib/features/pipenv:2": {},
"ghcr.io/devcontainers-contrib/features/pylint:2": {}
}
}
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
- uses: actions/setup-python@v4
with:
python-version: '3.11'
cache: 'pipenv' # caching pipenv dependencies
- name: Install pipenv and pipx
cache: 'pipenv' # TODO: how to cache poetry?
- name: Install poetry
run: |
pip install pipenv && pip install pipx
pip install poetry && pip install pipx
- name: Install global dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .so_pip.ini
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,4 @@ POSSIBLE_LANGUAGES = ['python','javascript','go','lua']

# cli client stuff
[SHELL_CONFIG]
SHELL = pipenv run
SHELL = poetry run
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ I personally am registering multiple keys for the same product.
To run a build
```
git clone https://github.com/matthewdeanmartin/so_pip.git
pipenv install --dev --skip-lock
poetry install --with dev
# todo list pipx installs, e.g. pylint, isort, etc.
pipenv shell
poetry shell
# verify code
python -m navio package
# update version number...
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Requires Python 3.11+
```
pip install so_pip
# or
pipenv install so_pip --pre --skip-lock
poetry install so_pip
so_pip vendorize my_name --question=31049648 --output=output
```
Expand Down
3 changes: 0 additions & 3 deletions dead_code/Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,3 @@ slpp = "*"

[requires]
python_version = "3.11"

[pipenv]
allow_prereleases = true
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ RUN python -m pip install --user pipx && python -m pipx ensurepath
RUN pipx install isort && \
pipx install pylint
RUN python -m pip install --no-cache-dir --upgrade pip --quiet \
&& pip install pipenv --no-cache-dir --quiet
&& pip install poetry --no-cache-dir --quiet
# Github action doesn't build a local package. But we have one on pypi!
# inexplicable fail with pipenv.
RUN pipx install "so-pip>=0.2.1"
Expand Down
6 changes: 3 additions & 3 deletions docker/Dockerfile_local
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ RUN python -m pip install --user pipx && python -m pipx ensurepath
RUN pipx install isort && \
pipx install pylint
RUN python -m pip install --no-cache-dir --upgrade pip --quiet \
&& pip install pipenv --no-cache-dir --quiet
&& pip install poetry --no-cache-dir --quiet
COPY dist/so_pip-*-py3-none-any.whl /app/
RUN pipenv install so_pip-*.whl --skip-lock
ENTRYPOINT ["pipenv", "run", "so_pip"]
RUN pip install so_pip-*.whl
ENTRYPOINT ["so_pip"]
2 changes: 1 addition & 1 deletion examples/self_managed_packages/.so_pip.ini
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ POSSIBLE_LANGUAGES = ["*"]

# cli client stuff
[SHELL_CONFIG]
SHELL = pipenv run
SHELL = poetry run
2 changes: 1 addition & 1 deletion examples/vendorize_to_src/.so_pip.ini
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ POSSIBLE_LANGUAGES = ["*"]

# cli client stuff
[SHELL_CONFIG]
SHELL = pipenv run
SHELL = poetry run
12 changes: 0 additions & 12 deletions pipx_installs.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# so these tools don't conflict with each other
pipx install isort
pipx install pygount
pipx install mypy
pipx install vulture

Expand All @@ -9,15 +8,4 @@ pipx install vulture
#pipx install pyupgrade
pipx install pylint
pipx install radon
pipx install flake8
pipx inject flake8 dlint mccabe pyflakes pep8-naming flake8-bugbear
pipx install pipenv-to-requirements
pipx install yamllint
pipx install apistar
pipx install openapi-spec-validator
pipx install jiggle_version
pipx install pyroma
pipx install twine
pipx install bandit

# pipx install "check-manifest==0.40"
2 changes: 1 addition & 1 deletion scripts/.so_pip.ini
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ POSSIBLE_LANGUAGES = ['python','javascript','go','lua']

# cli client stuff
[SHELL_CONFIG]
SHELL = pipenv run
SHELL = poetry run

0 comments on commit be94be0

Please sign in to comment.