Only schedule update if prop value has changed #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Typescript compilation error due to unsubscribe property not existing on ContextDetail when a context is used without a provider.
|
Looks good, would you mind rebasing with master to see if the tests pass? Sorry again for missing this. |
|
Hey @matthewp, no worries, looking forward to getting this wrapped up. I'm fairly new to rebasing and could use some guidance on this one. As far as I can tell, my branch is up-to-date and only one commit (this PR) ahead of your master. Also, I believe the Travis CI build will continue to fail as long as there's the unresolved Typescript warning (fixed in #223). If you merge that PR or fix it yourself, I think you'll find that the checks start passing. |
|
Ah, you're right! |
|
Ok, now a rebase. From your branch: |
Add a check to reflectiveProp that gives it similar behavior to useState and attributeChangedCallback: an update is only scheduled if the prop's value has changed.
|
Cool, thanks @matthewp, I think we're good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check to
reflectivePropthat gives it similar behavior touseStateandattributeChangedCallback: an update is only scheduled if the prop's value has changed.Fixes #192