Skip to content

Commit

Permalink
fixing via comments from sandeen
Browse files Browse the repository at this point in the history
  • Loading branch information
mtaumike committed Feb 6, 2019
1 parent e2a855e commit cb10cd5
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions bin/btmon.py
Original file line number Diff line number Diff line change
Expand Up @@ -1255,6 +1255,12 @@
MQTT_UPLOAD_PERIOD = MINUTE


# sumo logic defaults
SUMO_URL = 'https://support.sumologic.com/hc/en-us'
SUMO_UPLOAD_PERIOD = MINUTE
SUMO_TIMEOUT = 15 # seconds


import base64
import bisect
import calendar
Expand Down Expand Up @@ -4835,9 +4841,9 @@ def _handle_urlopen_error(self, e, url, payload):
options.mqtt_upload_period or MQTT_UPLOAD_PERIOD))
if options.sumo_out:
procs.append(SumoLogicProcessor
(options.sumo_url or OEM_URL,
options.sumo_upload_period or OEM_UPLOAD_PERIOD,
options.sumo_timeout or OEM_TIMEOUT))
(options.sumo_url or SUMO_URL,

This comment has been minimized.

Copy link
@sandeen

sandeen Feb 6, 2019

https://support.sumologic.com/hc/en-us will still fail the put request, if you don't have a meaningful default for a data collection endpoint I'd just bail out of btmon with an error.

options.sumo_upload_period or SUMO_UPLOAD_PERIOD,
options.sumo_timeout or SUMO_TIMEOUT))

mon = Monitor(col, procs)
mon.run()
Expand Down

0 comments on commit cb10cd5

Please sign in to comment.