make w2w compatible with numpy 2.0 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jkittner, thanks for following up on this. Ok for me to wait until the update has been fixed in rasterio. |
|
Hey @jkittner, As my long overdue task, I wanted to see whether I could accept pull request #127. Now, quite some fail, but it seems that this is due to the changes in numpy2 as well? So what do you reckon: should we accept the pull request as such, or wait for this to be resolved? Alternatively, we could keep this dev branch, and just update the README that describes the situation with WRF versions, and that users working with versions X and Y should install this development branch? |
jkittner
force-pushed
the
numpy2-compat
branch
from
4809cc6
to
272a486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just saw CI failing - it's due to numpy 2.0 being released.
The tests are failing because of: rasterio/rasterio#3109
we have to wait until this is fixed or pin numpy <2 - but I'd like to avoid that for now.